Skip to content

Improve Deployment Scripts #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 3 tasks
davidz627 opened this issue Jun 29, 2018 · 9 comments · Fixed by #364
Closed
2 of 3 tasks

Improve Deployment Scripts #37

davidz627 opened this issue Jun 29, 2018 · 9 comments · Fixed by #364
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone

Comments

@davidz627
Copy link
Contributor

davidz627 commented Jun 29, 2018

  • Make GCP service account token file user configuratable
  • Figure out actual minimal permissions set required for GCP service account
  • Make namespace configurable
@davidz627 davidz627 added this to the Beta milestone Jun 29, 2018
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/enhancement labels Jun 29, 2018
@davidz627
Copy link
Contributor Author

Ideally the user can run 1 script for an End to End deployment, that checks whether things (service account, role bindings, json keys) already exist, and if not, creates them, then is able to deploy the driver. And maybe even clean up the key from the machine afterwards.

@davidz627
Copy link
Contributor Author

/cc @msau42 Does this seem like a reasonable thing to do ^

@msau42
Copy link
Contributor

msau42 commented Jul 11, 2018

Sure sounds reasonable

@davidz627
Copy link
Contributor Author

GCP Service Account token file directory configurable: #81
Minimal permissions: #73

Still todo:

  • Make namespace configurable

@davidz627 davidz627 modified the milestones: Beta, GA Sep 26, 2018
@saad-ali
Copy link
Contributor

Should the default namespace be default? Or would it be better to have a GCE PD specific namespace?

@msau42
Copy link
Contributor

msau42 commented Dec 20, 2018

Better to have a special namespace just for the driver

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2019
@davidz627
Copy link
Contributor Author

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 29, 2019
@davidz627
Copy link
Contributor Author

namespace shouldn't be configurable, actually will just be set directly

jsafrane pushed a commit to jsafrane/gcp-compute-persistent-disk-csi-driver that referenced this issue Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants