Skip to content

Give more descriptive filenames for sample deployment #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
msau42 opened this issue Jul 17, 2018 · 1 comment
Closed

Give more descriptive filenames for sample deployment #72

msau42 opened this issue Jul 17, 2018 · 1 comment

Comments

@msau42
Copy link
Contributor

msau42 commented Jul 17, 2018

These are really generic names:
$ export SA_FILE=~/.../cloud-sa.json
$ export GCEPD_SA_NAME=sample-service-account

It may be better go prefix them with "gce-pd-csi" or something like that.

Also as a side note, because the SA_FILE filename must be cloud-sa.json, it may be better to make the directory configurable, rather than the filename configurable.
@davidz627
Copy link
Contributor

solved by #81

jsafrane pushed a commit to jsafrane/gcp-compute-persistent-disk-csi-driver that referenced this issue Apr 16, 2025
@openshift-merge-bot
Merge pull request kubernetes-sigs#72 from dfajmon/rebase-v1.15.2
14fa4d9 
STOR-2012: Rebase to upstream v1.15.2 for OCP 4.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidz627 @msau42