Update docs/stable overlay to reference new release #658

saad-ali · 2020-11-06T04:35:54Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Update docs and stable overlay to reference new release (1.1.0).
Move leader election and volume in use patches to base overlay.
Switch sidecar images to k8s.gcr.io/sig-storage/ and gcr.io/k8s-staging-sig-storage.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

/assign @msau42

k8s-ci-robot · 2020-11-06T04:36:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [saad-ali]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deploy/kubernetes/images/stable/image.yaml

saad-ali

PTAL

deploy/kubernetes/base/controller/controller.yaml

saad-ali · 2020-11-09T09:10:36Z

W1107 00:10:28.572]   Warning  Failed       28s   kubelet            Error: ErrImagePull
W1107 00:10:28.572]   Normal   Pulling      28s   kubelet            Pulling image "gke.gcr.io/csi-attacher:v3.0.1-gke.0"
W1107 00:10:28.573]   Warning  Failed       28s   kubelet            Failed to pull image "gke.gcr.io/csi-attacher:v3.0.1-gke.0": rpc error: code = NotFound desc = failed to pull and unpack image "gke.gcr.io/csi-attacher:v3.0.1-gke.0": failed to resolve reference "gke.gcr.io/csi-attacher:v3.0.1-gke.0": gke.gcr.io/csi-attacher:v3.0.1-gke.0: not found
W1107 00:10:28.573]   Warning  Failed       28s   kubelet            Error: ErrImagePull
W1107 00:10:28.573]   Normal   Pulling      28s   kubelet            Pulling image "gke.gcr.io/csi-resizer:v1.0.1-gke.0"
W1107 00:10:28.574]   Warning  Failed       28s   kubelet            Failed to pull image "gke.gcr.io/csi-resizer:v1.0.1-gke.0": rpc error: code = NotFound desc = failed to pull and unpack image "gke.gcr.io/csi-resizer:v1.0.1-gke.0": failed to resolve reference "gke.gcr.io/csi-resizer:v1.0.1-gke.0": gke.gcr.io/csi-resizer:v1.0.1-gke.0: not found
W1107 00:10:28.574]   Warning  Failed       28s   kubelet            Error: ErrImagePull
W1107 00:10:28.574]   Normal   Pulling      28s   kubelet            Pulling image "gke.gcr.io/csi-snapshotter:v3.0.1-gke.0"
W1107 00:10:28.574]   Normal   Pulling      28s   kubelet            Pulling image "gke.gcr.io/csi-provisioner:v2.0.3-gke.0"
W1107 00:10:28.575]   Warning  Failed       28s   kubelet            Error: ErrImagePull
W1107 00:10:28.575]   Warning  Failed       28s   kubelet            Failed to pull image "gke.gcr.io/csi-snapshotter:v3.0.1-gke.0": rpc error: code = NotFound desc = failed to pull and unpack image "gke.gcr.io/csi-snapshotter:v3.0.1-gke.0": failed to resolve reference "gke.gcr.io/csi-snapshotter:v3.0.1-gke.0": gke.gcr.io/csi-snapshotter:v3.0.1-gke.0: not found

@msau42 When are the new sidecar images going to be promoted?

saad-ali · 2020-11-10T09:25:44Z

PTAL

deploy/kubernetes/base/controller/controller.yaml

msau42 · 2020-11-10T17:19:46Z

deploy/kubernetes/images/prow-gke-release-staging-head/image.yaml

@@ -12,8 +12,8 @@ kind: ImageTagTransformer
 metadata:
  name: imagetag-csi-provisioner-prow-head
 imageTag:
-  name: gke.gcr.io/csi-provisioner
-  newName: quay.io/k8scsi/csi-provisioner
+  name: k8s.gcr.io/sig-storage/csi-provisioner


Are there any alpha/dev image transformations that need to be updated?

No. Alpha only overrides the driver image, not the sidecars. And dev just uses alpha image transformers.

msau42 · 2020-11-12T16:50:28Z

deploy/kubernetes/images/prow-gke-release-staging-rc/image.yaml

-  newName: gcr.io/gke-release-staging/csi-provisioner
-  newTag: "v2.0.3-gke.0"
+  name: k8s.gcr.io/sig-storage/csi-provisioner
+  newName: gcr.io/k8s-staging-sig-storage/csi-provisioner


staging-rc could remain on k8s.gcr.io/sig-storage since it's still using released images

Do we not want to push it to use the latest available released staging image?

For pd driver image, I think using the staging repo makes sense.

But I'm not sure about CSI sidecars. We don't use internal pdcsi tests as an indicator for OSS CSI sidecar releases.

Good point. We don't need to test unreleased versions of sidecars in this repo.

jingxu97 · 2020-11-12T21:37:30Z

before updating stable overlay, is there a testing phase? Or we just use stable overlay for testing.

jingxu97 · 2020-11-12T22:13:50Z

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-win2019

msau42 · 2020-11-12T22:20:10Z

before updating stable overlay, is there a testing phase? Or we just use stable overlay for testing.

The pull job tests stable overlay with custom built pd driver image, so doesn't exactly reflect the stable overlay.

The closest thing we have to pretesting stable overlay is the staging-rc overlay, so it's good to make sure they match as close as possible.

Update docs and stable overlay to reference new release (1.1.0). Move leader election and volume in use patches to base overlay. Switch sidecar images to k8s.gcr.io/sig-storage/ and gcr.io/k8s-staging-sig-storage

saad-ali · 2020-11-13T09:46:38Z

PTAL

jingxu97 · 2020-11-13T17:51:15Z

deploy/kubernetes/base/controller/controller.yaml

+          # - "--run-controller-service=false"  # disable the controller service of the CSI driver
+          # - "--run-node-service=false"        # disable the node service of the CSI driver
+            - "--leader-election"
+            - "--default-fstype=ext4"


do we need to set default fstype?
If the reason we need to set it due to issue related to fsgroup will be ignored if default fstype is not set, kubernetes-sigs/vsphere-csi-driver#370 (comment)

This logic should be fixed in 1.19 by kubernetes/kubernetes#92001. This means for testing k/k 1.19 and above, no need to set default-fstype here. During format and mount, the default fstype will be applied depending on OS.

So for OSS test which using the latest kubernetes, we don't need to set default value here so we can test the behavior of correctly setting fstype by driver.

For internal tests which tests earlier version of kubernetes, it also seems ok so far without setting default-fstype. From what I searched, we didn't test fsgroup behavior yet.

There is a new test added very recently for 1.20. https://github.com/kubernetes/kubernetes/blame/master/test/e2e/storage/testsuites/fsgroupchangepolicy.go

So I think from testing point, should be ok without setting default value here.

I agree we don't need it staring with Kubernetes 1.20. In 1.19 it's still an alpha feature and not enabled by default.

I think for the purposes of this PR, which is to cleanup the overlays for the already released driver, we should still keep it.

For the next driver release, we can look into removing it along with adding the CSIDriver change. It will also bump up the min version of this driver to Kubernetes 1.20

Opened #668 to track this since this PR has merged.

msau42 · 2020-11-13T22:12:18Z

/lgtm

Cherrypick #658 from `master` to `release-1.1`

k8s-ci-robot assigned msau42 Nov 6, 2020

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Nov 6, 2020

k8s-ci-robot requested review from jingxu97 and verult November 6, 2020 04:36

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2020

saad-ali mentioned this pull request Nov 6, 2020

Cherrypick #658 from master to release-1.1 #659

Merged

msau42 reviewed Nov 6, 2020

View reviewed changes

deploy/kubernetes/images/stable/image.yaml Show resolved Hide resolved

saad-ali force-pushed the updateDocsAndOveraly branch from a88c20d to cbfc795 Compare November 6, 2020 23:35

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2020

saad-ali commented Nov 6, 2020

View reviewed changes

saad-ali force-pushed the updateDocsAndOveraly branch from cbfc795 to 02a86e8 Compare November 6, 2020 23:37

msau42 reviewed Nov 7, 2020

View reviewed changes

deploy/kubernetes/base/controller/controller.yaml Outdated Show resolved Hide resolved

saad-ali force-pushed the updateDocsAndOveraly branch from 02a86e8 to 07cd01d Compare November 9, 2020 09:09

saad-ali force-pushed the updateDocsAndOveraly branch from 07cd01d to 44700fc Compare November 10, 2020 09:23

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 10, 2020

msau42 reviewed Nov 10, 2020

View reviewed changes

saad-ali force-pushed the updateDocsAndOveraly branch from 44700fc to 776e647 Compare November 12, 2020 07:20

msau42 reviewed Nov 12, 2020

View reviewed changes

Update docs/stable overlay to reference new release

7a715d0

Update docs and stable overlay to reference new release (1.1.0). Move leader election and volume in use patches to base overlay. Switch sidecar images to k8s.gcr.io/sig-storage/ and gcr.io/k8s-staging-sig-storage

saad-ali force-pushed the updateDocsAndOveraly branch from 776e647 to 7a715d0 Compare November 13, 2020 09:45

jingxu97 reviewed Nov 13, 2020

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020

k8s-ci-robot merged commit 9a52928 into kubernetes-sigs:master Nov 13, 2020

k8s-ci-robot added a commit that referenced this pull request Nov 13, 2020

Merge pull request #659 from saad-ali/release-1.1

acd6c06

Cherrypick #658 from `master` to `release-1.1`

saad-ali mentioned this pull request Nov 13, 2020

do we need to set default fstype #668

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update docs/stable overlay to reference new release #658

Update docs/stable overlay to reference new release #658

saad-ali commented Nov 6, 2020 •

edited

Loading

k8s-ci-robot commented Nov 6, 2020

saad-ali left a comment

saad-ali commented Nov 9, 2020

saad-ali commented Nov 10, 2020

msau42 Nov 10, 2020

saad-ali Nov 12, 2020

msau42 Nov 12, 2020

saad-ali Nov 12, 2020

msau42 Nov 12, 2020

saad-ali Nov 13, 2020

jingxu97 commented Nov 12, 2020

jingxu97 commented Nov 12, 2020

msau42 commented Nov 12, 2020

saad-ali commented Nov 13, 2020

jingxu97 Nov 13, 2020

msau42 Nov 13, 2020

saad-ali Nov 13, 2020

msau42 commented Nov 13, 2020

Update docs/stable overlay to reference new release #658

Update docs/stable overlay to reference new release #658

Conversation

saad-ali commented Nov 6, 2020 • edited Loading

k8s-ci-robot commented Nov 6, 2020

saad-ali left a comment

Choose a reason for hiding this comment

saad-ali commented Nov 9, 2020

saad-ali commented Nov 10, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jingxu97 commented Nov 12, 2020

jingxu97 commented Nov 12, 2020

msau42 commented Nov 12, 2020

saad-ali commented Nov 13, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msau42 commented Nov 13, 2020

saad-ali commented Nov 6, 2020 •

edited

Loading