do we need to set default fstype

[saad-ali]

Jing left a comment on a PR (#658 (comment)), copying here to ensure it does not get missed:

do we need to set default fstype?
If the reason we need to set it due to issue related to fsgroup will be ignored if default fstype is not set, kubernetes-sigs/vsphere-csi-driver#370 (comment)

This logic should be fixed in 1.19 by kubernetes/kubernetes#92001. This means for testing k/k 1.19 and above, no need to set default-fstype here. During format and mount, the default fstype will be applied depending on OS.

So for OSS test which using the latest kubernetes, we don't need to set default value here so we can test the behavior of correctly setting fstype by driver.

For internal tests which tests earlier version of kubernetes, it also seems ok so far without setting default-fstype. From what I searched, we didn't test fsgroup behavior yet.

There is a new test added very recently for 1.20. https://github.com/kubernetes/kubernetes/blame/master/test/e2e/storage/testsuites/fsgroupchangepolicy.go

So I think from testing point, should be ok without setting default value here.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.