Skip to content

Cherrypick #658 from master to release-1.1 #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2020
Merged

Cherrypick #658 from master to release-1.1 #659

merged 1 commit into from
Nov 13, 2020

Conversation

saad-ali
Copy link
Contributor

@saad-ali saad-ali commented Nov 6, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Cherrypick #658 from master to release-1.1: Update docs/stable overlay to reference new release

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

/assign @msau42

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 12, 2020
@jingxu97
Copy link
Contributor

jingxu97 commented Nov 12, 2020 •
edited
Loading

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-win2019

trigger windows tests first.

@k8s-ci-robot
Copy link
Contributor

@jingxu97: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-gcp-compute-persistent-disk-csi-driver-e2e
  • /test pull-gcp-compute-persistent-disk-csi-driver-sanity
  • /test pull-gcp-compute-persistent-disk-csi-driver-unit
  • /test pull-gcp-compute-persistent-disk-csi-driver-verify
  • /test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

Use /test all to run all jobs.

In response to this:

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-win2019

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jingxu97
Copy link
Contributor

jingxu97 commented Nov 12, 2020 •
edited
Loading

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-win2019

why I cannot trigger windows test?

@k8s-ci-robot
Copy link
Contributor

@jingxu97: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-gcp-compute-persistent-disk-csi-driver-e2e
  • /test pull-gcp-compute-persistent-disk-csi-driver-sanity
  • /test pull-gcp-compute-persistent-disk-csi-driver-unit
  • /test pull-gcp-compute-persistent-disk-csi-driver-verify
  • /test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

Use /test all to run all jobs.

In response to this:

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-win2019

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saad-ali
Update docs/stable overlay to reference new release
ed69d33 
Update docs and stable overlay to reference new release (1.1.0).
Move leader election and volume in use patches to base overlay.
Switch sidecar images to k8s.gcr.io/sig-storage/ and
gcr.io/k8s-staging-sig-storage
@saad-ali
Copy link
Contributor Author

why I cannot trigger windows test?

Is it configured for the release branch?

@jingxu97
Copy link
Contributor

why I cannot trigger windows test?

Is it configured for the release branch?

oh, got it. it is for release branch.

@msau42
Copy link
Contributor

msau42 commented Nov 13, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit acd6c06 into kubernetes-sigs:release-1.1 Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@mattcary mattcary Awaiting requested review from mattcary

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saad-ali @k8s-ci-robot @jingxu97 @msau42