Skip to content

Automated cherry pick of #1666: migrate hyperdisk/chd/storagepools to GCE v1 disk API #1667: remove support for GCE Alpha Disks #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2024
Merged

Automated cherry pick of #1666: migrate hyperdisk/chd/storagepools to GCE v1 disk API #1667: remove support for GCE Alpha Disks #1669

merged 2 commits into from
Apr 18, 2024

Conversation

amacaskill
Copy link
Member

@amacaskill amacaskill commented Apr 16, 2024 •
edited
Loading

Cherry pick of #1666 #1667 on release-1.13.

#1666: migrate hyperdisk/chd/storagepools to GCE v1 disk API
#1667: remove support for GCE Alpha Disks

For details on the cherry pick process, see the cherry pick requests page.

Migrate Hyperdisk/CHD/StoragePools to GCE v1 disk API, and remove support for GCE alpha disk API.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amacaskill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 16, 2024
@amacaskill amacaskill force-pushed the automated-cherry-pick-of-#1666-#1667-upstream-release-1.13 branch from b8ea58e to a11bdd6 Compare April 16, 2024 21:07
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 16, 2024
@amacaskill
Copy link
Member Author

/assign @sunnylovestiramisu

@sunnylovestiramisu
Copy link
Contributor

/retest

@sunnylovestiramisu
Copy link
Contributor

For the integ tests, the build failed.

@amacaskill
Copy link
Member Author

amacaskill commented Apr 16, 2024 •
edited
Loading

For the integ tests, the build failed.

Its also failing in another PR I have. It isn't related to this change. The error is (gcloud.compute.instances.create) Must specify either [--image] or [--image-family] when specifying [--image-project] flag.

Looks like master-helper.sh calls gcloud.compute.instances.create with both --image and --image-project, and this file hasn't been updated in 2 years. It doesn't specify --image-family so I don't see why this error is happening.

@amacaskill
Copy link
Member Author

/retest

@sunnylovestiramisu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit cfe53f7 into kubernetes-sigs:release-1.13 Apr 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

@songjiaxun songjiaxun Awaiting requested review from songjiaxun

Assignees

@sunnylovestiramisu sunnylovestiramisu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amacaskill @k8s-ci-robot @sunnylovestiramisu