Skip to content

Remove support for GCE Alpha Disk Insert API #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2024
Merged

Remove support for GCE Alpha Disk Insert API #1667

merged 1 commit into from
Apr 16, 2024

Conversation

amacaskill
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This is a follow up PR to PR 1666, which Migrated Hyperdisk/CHD/StoragePools features to the GCE v1 disk API. Now that no features are using the GCE alpha disk API, this PR removes support for Alpha Disks. It also adds v1 support to CloudDisk (/gce-cloud-provider/compute/cloud-disk.go) for the Hyperdisk/CHD/StoragePools features (d *CloudDisk) GetEnableConfidentialCompute()`

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Remove support for GCE Alpha Disk Insert API.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amacaskill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 16, 2024
@amacaskill
Copy link
Member Author

/assign @sunnylovestiramisu

sunnylovestiramisu
sunnylovestiramisu reviewed Apr 16, 2024
View reviewed changes
pkg/gce-cloud-provider/compute/cloud-disk.go
@@ -134,8 +115,6 @@ func (d *CloudDisk) GetPDType() string {
pdType = d.disk.Type
case d.betaDisk != nil:
pdType = d.betaDisk.Type
case d.alphaDisk != nil:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will this impact the endpoint in TPC?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just that in TPC it will also only use beta/v1 which should not be a problem

@sunnylovestiramisu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2024
@amacaskill amacaskill merged commit 1055c3c into kubernetes-sigs:master Apr 16, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@amacaskill: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration 53cf99a link unknown /test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@amacaskill amacaskill mentioned this pull request Apr 16, 2024
Merged
k8s-ci-robot added a commit that referenced this pull request Apr 18, 2024
@k8s-ci-robot
Merge pull request #1669 from amacaskill/automated-cherry-pick-of-#1666-
cfe53f7 
#1667-upstream-release-1.13

Automated cherry pick of #1666: migrate hyperdisk/chd/storagepools to GCE v1 disk API
#1667: remove support for GCE Alpha Disks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunnylovestiramisu sunnylovestiramisu sunnylovestiramisu left review comments

@pwschuurman pwschuurman Awaiting requested review from pwschuurman

@songjiaxun songjiaxun Awaiting requested review from songjiaxun

Assignees

@sunnylovestiramisu sunnylovestiramisu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amacaskill @k8s-ci-robot @sunnylovestiramisu