-
Notifications
You must be signed in to change notification settings - Fork 159
Migrate Hyperdisk/CHD/StoragePools to GCE v1 disk API #1666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Hyperdisk/CHD/StoragePools to GCE v1 disk API #1666
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amacaskill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c7cf37b
to
deee156
Compare
/assign @sunnylovestiramisu |
/hold going to test on GKE cluster before this gets submitted. |
/hold cancel |
/lgtm |
/cherry-pick release-1.13 |
@amacaskill: new pull request created: #1668 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Now that the provisionedIops, provisionedThroughput, enableConfidentialCompute, and storagePool are supported by the GCE v1 disks insert API, this PR migrates the disk insert call to alpha/beta --> v1 for these features. This allows us to clean up the code in /pkg/gce-cloud-provider/compute/gce-compute.go. Multiwriter still requires the GCE beta disks insert API, so the multiwriter feature cannot be migrated to v1 API. I will clean up the Alpha API support, added in PR 1524, in a child PR.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: