Skip to content

Migrate Hyperdisk/CHD/StoragePools to GCE v1 disk API #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

amacaskill
Copy link
Member

@amacaskill amacaskill commented Apr 15, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Now that the provisionedIops, provisionedThroughput, enableConfidentialCompute, and storagePool are supported by the GCE v1 disks insert API, this PR migrates the disk insert call to alpha/beta --> v1 for these features. This allows us to clean up the code in /pkg/gce-cloud-provider/compute/gce-compute.go. Multiwriter still requires the GCE beta disks insert API, so the multiwriter feature cannot be migrated to v1 API. I will clean up the Alpha API support, added in PR 1524, in a child PR.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Migrate the Hyperdisk/CHD/StoragePools features to the GCE v1 insert disk API.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amacaskill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 15, 2024
@amacaskill amacaskill changed the title migrate hyperdisk/chd/storagepools to GCE v1 disk API Migrate Hyperdisk/CHD/StoragePools to GCE v1 disk API Apr 15, 2024
@amacaskill
Copy link
Member Author

/assign @sunnylovestiramisu

@amacaskill
Copy link
Member Author

/hold going to test on GKE cluster before this gets submitted.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2024
@amacaskill
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2024
@sunnylovestiramisu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit f038ec0 into kubernetes-sigs:master Apr 16, 2024
7 checks passed
@amacaskill
Copy link
Member Author

/cherry-pick release-1.13

@k8s-infra-cherrypick-robot

@amacaskill: new pull request created: #1668

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added a commit that referenced this pull request Apr 18, 2024
#1667-upstream-release-1.13

Automated cherry pick of #1666: migrate hyperdisk/chd/storagepools to GCE v1 disk API
#1667: remove support for GCE Alpha Disks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants