Skip to content

Pin the buildkit version to v0.10.6 #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mauriciopoppe
Copy link
Member

@mauriciopoppe mauriciopoppe commented Feb 7, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Followup of #1124 and #1126. In https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-gce-pd-csi-driver-latest-k8s-master-windows-2019/1622984251899121664 docker manifest create is failing with

I0207 11:50:07.220] DOCKER_CLI_EXPERIMENTAL=enabled docker manifest create --amend gcr.io/e2e-gce-gci-ci-master/gcp-persistent-disk-csi-driver:ec610dec-b6e3-4e8e-b3ed-28dbf81dd659 gcr.io/e2e-gce-gci-ci-master/gcp-persistent-disk-csi-driver:ec610dec-b6e3-4e8e-b3ed-28dbf81dd659_linux_amd64 gcr.io/e2e-gce-gci-ci-master/gcp-persistent-disk-csi-driver:ec610dec-b6e3-4e8e-b3ed-28dbf81dd659_ltsc2019
W0207 11:50:09.546] gcr.io/e2e-gce-gci-ci-master/gcp-persistent-disk-csi-driver:ec610dec-b6e3-4e8e-b3ed-28dbf81dd659_linux_amd64 is a manifest list
W0207 11:50:09.552] make: *** [Makefile:64: build-and-push-multi-arch] Error 1
I0207 11:50:09.653] make: Leaving directory '/go/src/sigs.k8s.io/gcp-compute-persistent-disk-csi-driver'
W0207 11:50:11.650] F0207 11:50:11.650246    7131 main.go:196] Failed to run integration test: %!w(*errors.errorString=&{failed pushing image: failed to run make command for windows: err: exit status 2})

My only guess is that this is similar to the issue we saw internally too and I reported upstream in docker/cli#3969, this is an attempt to see what happens in CI if we pin the version because I can't reproduce it locally.

Does this PR introduce a user-facing change?:

NONE

/cc @mattcary

@k8s-ci-robot k8s-ci-robot requested a review from mattcary February 7, 2023 21:01
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2023
@mattcary
Copy link
Contributor

mattcary commented Feb 7, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, mauriciopoppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 831d1ea into kubernetes-sigs:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants