Skip to content

Remove linux/arm64 from Windows multi-arch builds #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mauriciopoppe
Copy link
Member

@mauriciopoppe mauriciopoppe commented Feb 3, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

CI started failing for Windows in the build-and-push-multi-arch step, after looking into the logs it failed to build the linux/arm64 image, I'm removing it from the OSS Windows CI tests.

I think we might have problems building the linux/arm64 image internally the next time there's a release, just an FYI.

Relevant logs https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-gce-pd-csi-driver-latest-k8s-master-windows-2019/1622138021719576576

W0121 03:11:25.673] #14 [builder 4/4] RUN GOARCH=$(echo linux/amd64 | cut -f2 -d '/') GCE_PD_CSI_STAGING_VERSION=c5f6ebfd-01bb-435b-93b6-7bf7a7f158e9 make gce-pd-driver
W0121 03:11:55.618] #14 36.18 # sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/cmd/gce-pd-csi-driver
W0121 03:11:55.619] #14 36.18 /usr/bin/ld: /tmp/go-link-3732353106/000003.o: in function `mygetgrouplist':
W0121 03:11:55.619] #14 36.18 /_/os/user/getgrouplist_unix.go:15: warning: Using 'getgrouplist' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
W0121 03:11:55.619] #14 36.18 /usr/bin/ld: /tmp/go-link-3732353106/000002.o: in function `mygetgrgid_r':
W0121 03:11:55.619] #14 36.18 /_/os/user/cgo_lookup_unix.go:37: warning: Using 'getgrgid_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
W0121 03:11:55.620] #14 36.18 /usr/bin/ld: /tmp/go-link-3732353106/000002.o: in function `mygetgrnam_r':
W0121 03:11:55.620] #14 36.18 /_/os/user/cgo_lookup_unix.go:42: warning: Using 'getgrnam_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
W0121 03:11:55.620] #14 36.18 /usr/bin/ld: /tmp/go-link-3732353106/000002.o: in function `mygetpwnam_r':
W0121 03:11:55.620] #14 36.18 /_/os/user/cgo_lookup_unix.go:32: warning: Using 'getpwnam_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
W0121 03:11:55.620] #14 36.18 /usr/bin/ld: /tmp/go-link-3732353106/000002.o: in function `mygetpwuid_r':
W0121 03:11:55.621] #14 36.18 /_/os/user/cgo_lookup_unix.go:27: warning: Using 'getpwuid_r' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
W0121 03:11:55.621] #14 36.18 /usr/bin/ld: /tmp/go-link-3732353106/000008.o: in function `_cgo_2ac87069779a_C2func_getaddrinfo':
W0121 03:11:55.621] #14 36.18 /tmp/go-build/cgo-gcc-prolog:58: warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
W0121 03:11:56.520] #14 DONE 37.1s

Does this PR introduce a user-facing change?:

NONE

/cc @mattcary

@k8s-ci-robot k8s-ci-robot requested a review from mattcary February 3, 2023 21:18
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 3, 2023
@mattcary
Copy link
Contributor

mattcary commented Feb 3, 2023

/lgtm
/approve

Do you have a link to the entire failing build?

I don't think this has been failing internally, I suspect the difference is that we build each arch from within an arch-specific docker build, whereas I think upstream they build all the archs externally, and then copy them in. Or maybe I'm wrong but at any rate I'd like to see the whole build process and I forget where to find it upstream.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, mauriciopoppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit a5f4bb0 into kubernetes-sigs:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants