Skip to content

Update buildkit version from 0.10.6 -> 0.11.3 #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2023
Merged

Update buildkit version from 0.10.6 -> 0.11.3 #1218

merged 1 commit into from
May 11, 2023

Conversation

pwschuurman
Copy link
Contributor

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
This updates the buildkit version from 0.10.6 -> 0.11.3. Version 0.11.3 contains a caching fix, which appears to be contributing to failures of the integration test (https://github.com/moby/buildkit/releases/tag/v0.11.3).

Which issue(s) this PR fixes:
Fixes #1217

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels May 9, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2023
@pwschuurman
Copy link
Contributor Author

/retest

@msau42
Copy link
Contributor

msau42 commented May 10, 2023

We had to pin to buildkit 0.10.x because of some issues impacting our multiarch build flow: #1127

@pwschuurman
Copy link
Contributor Author

pwschuurman commented May 10, 2023 •
edited
Loading

We had to pin to buildkit 0.10.x because of some issues impacting our multiarch build flow: #1127

I think the issue we pinned it for (moby/moby#43126) was resolved in Docker 23.0.0 (docker/cli#3990): https://github.com/docker/cli/releases/tag/v23.0.0

The currently builder image for the ci-windows integration test is "gcr.io/k8s-staging-test-infra/kubekins-e2e:v20230406-23cb1879e3-master", which has "Docker version 23.0.1, build a5ee5b1"

So I think the original OCI issue should be resolved anyway, and we can upgrade Buildkit past 0.11.0

Additionally, the Windows build is currently failing anyway (https://testgrid.k8s.io/provider-gcp-compute-persistent-disk-csi-driver#ci-windows-2019-provider-gcp-compute-persistent-disk-csi-driver), so I don't see the harm in making this change to fix the general integration test (at least we can unblock developers).

@pwschuurman pwschuurman marked this pull request as ready for review May 10, 2023 22:01
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2023
@k8s-ci-robot k8s-ci-robot requested a review from msau42 May 10, 2023 22:01
@msau42
Copy link
Contributor

msau42 commented May 10, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@pwschuurman
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit deee7b0 into kubernetes-sigs:master May 11, 2023
This was referenced May 12, 2023
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request May 16, 2023
@k8s-ci-robot
Merge pull request #1225 from pwschuurman/automated-cherry-pick-of-#1…
90fc973 
…218-upstream-release-1.10

Automated cherry pick of #1218: Update buildkit version from 0.10.6 -> 0.11.3
k8s-ci-robot added a commit that referenced this pull request May 16, 2023
@k8s-ci-robot
Merge pull request #1226 from pwschuurman/automated-cherry-pick-of-#1…
68d70b8 
…218-upstream-release-1.9

Automated cherry pick of #1218: Update buildkit version from 0.10.6 -> 0.11.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

@sunnylovestiramisu sunnylovestiramisu Awaiting requested review from sunnylovestiramisu

@msau42 msau42 Awaiting requested review from msau42

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration test failure due to missing layer
3 participants
@pwschuurman @k8s-ci-robot @msau42