-
Notifications
You must be signed in to change notification settings - Fork 159
limit grpc logging info to a configurable character limit #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leiyiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
lgtm but just looks like you need to change the tests that call gceDriver.Run(endpoint) --> gceDriver.Run(endpoint, grpcLogCharCap) |
/test pull-gcp-compute-persistent-disk-csi-driver-sanity |
fixed test failure, @amacaskill ptal |
Hey there! Just letting you know that I have just fixed and re-enabled the sanity tests for PD in go/pdcsi-oss-driver/issues/990 so if you experience failures in your sanity test PR gate build because you're on an old branch before the tests were fixed, merging the latest commits from master into this branch it should make them pass. Let me know if you have any questions! |
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
ListVolume call generates tons of log items because by default the entirety of the grpc response body gets logged out. That consumes log space really fast and we want to limit how much can be logged in the same message.
This might impact some visibility into what's going on with ListVolume call.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
didn't find obvious way to make the log limit configurable. Pls advise of otherwise
Does this PR introduce a user-facing change?: