limit logging info to 10000 char maximum

leiyiz · leiyiz · commit a55cd56ea234 · 2022-11-18T15:54:06.000-08:00
diff --git a/pkg/gce-pd-csi-driver/utils.go b/pkg/gce-pd-csi-driver/utils.go
@@ -28,7 +28,8 @@ import (
 )
 
 const (
-	fsTypeXFS = "xfs"
+	fsTypeXFS  = "xfs"
+	maxLogChar = 10000
 )
 
 var ProbeCSIFullMethod = "/csi.v1.Identity/Probe"
@@ -69,7 +70,11 @@ func logGRPC(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, h
 	if err != nil {
 		klog.Errorf("%s returned with error: %v", info.FullMethod, err)
 	} else {
-		klog.V(4).Infof("%s returned with response: %s", info.FullMethod, resp)
+		cappedStr := fmt.Sprintf("%v", resp)
+		if len(cappedStr) > maxLogChar {
+			cappedStr = cappedStr[:maxLogChar] + fmt.Sprintf(" [response body too large, log capped to %d chars]", maxLogChar)
+		}
+		klog.V(4).Infof("%s returned with response: %s", info.FullMethod, cappedStr)
 	}
 	return resp, err
 }

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,8 @@ import (`
`28`	`28`	`)`
`29`	`29`
`30`	`30`	`const (`
`31`		`- fsTypeXFS = "xfs"`
	`31`	`+ fsTypeXFS = "xfs"`
	`32`	`+ maxLogChar = 10000`
`32`	`33`	`)`
`33`	`34`
`34`	`35`	`var ProbeCSIFullMethod = "/csi.v1.Identity/Probe"`
`@@ -69,7 +70,11 @@ func logGRPC(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, h`
`69`	`70`	`if err != nil {`
`70`	`71`	`klog.Errorf("%s returned with error: %v", info.FullMethod, err)`
`71`	`72`	`} else {`
`72`		`- klog.V(4).Infof("%s returned with response: %s", info.FullMethod, resp)`
	`73`	`+ cappedStr := fmt.Sprintf("%v", resp)`
	`74`	`+ if len(cappedStr) > maxLogChar {`
	`75`	`+ cappedStr = cappedStr[:maxLogChar] + fmt.Sprintf(" [response body too large, log capped to %d chars]", maxLogChar)`
	`76`	`+ }`
	`77`	`+ klog.V(4).Infof("%s returned with response: %s", info.FullMethod, cappedStr)`
`73`	`78`	`}`
`74`	`79`	`return resp, err`
`75`	`80`	`}`