Disable per volume backoff behavior for sanity tests #1094
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
|
Hi @judemars. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XS
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/test pull-gcp-compute-persistent-disk-csi-driver-sanity |
|
/test pull-gcp-compute-persistent-disk-csi-driver-sanity |
|
/test pull-gcp-compute-persistent-disk-csi-driver-sanity |
|
/test pull-gcp-compute-persistent-disk-csi-driver-sanity |
|
/test pull-gcp-compute-persistent-disk-csi-driver-sanity |
|
/test pull-gcp-compute-persistent-disk-csi-driver-sanity |
|
/test pull-gcp-compute-persistent-disk-csi-driver-sanity |
|
/test pull-gcp-compute-persistent-disk-csi-driver-sanity |
|
/test pull-gcp-compute-persistent-disk-csi-driver-sanity |
|
/test pull-gcp-compute-persistent-disk-csi-driver-sanity |
|
That's the last test I'll do, but I'll keep an eye on the runs once I re-add it as a PR gate |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
saikat-royc
changed the title
test/sanity/sanity_test.go
Outdated
| @@ -66,7 +66,7 @@ func TestSanity(t *testing.T) { | |||
|
|
|||
| //Initialize GCE Driver | |||
| identityServer := driver.NewIdentityServer(gceDriver) | |||
| controllerServer := driver.NewControllerServer(gceDriver, cloudProvider, 1*time.Millisecond, 5*time.Minute) | |||
| controllerServer := driver.NewControllerServer(gceDriver, cloudProvider, 0*time.Millisecond, 5*time.Minute) | |||
There was a problem hiding this comment.
just 0 is sufficient I think
There was a problem hiding this comment.
Done, and here is the passing sanity test after that change: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/sigs.k8s.io_gcp-compute-persistent-disk-csi-driver/1094/pull-gcp-compute-persistent-disk-csi-driver-sanity/1598452725211729920/
|
/test pull-gcp-compute-persistent-disk-csi-driver-sanity /retest |
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: judemars, saikat-royc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…#1094) * Lower threshold of backoff for sanity tests * Switch to zero * Rm millisecond
What type of PR is this?
kind failing-test
What this PR does / why we need it:
Lower threshold for backoff in pd sanity tests
This is a follow up to #1087. It lowers the threshold for backoff in sanity tests even more since we were seeing flakes in some PR gating tests, namely #1092.
I will run the sanity tests a few times in this CL before merging.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: