Skip to content

Fixing errors in new template & disabling the default blank template #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

kfswain
Copy link
Collaborator

@kfswain kfswain commented Apr 25, 2025

This indirection allows us to apply labels on all issues being created, making triage simpler.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2025
Copy link

netlify bot commented Apr 25, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit a67dc59
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/680be22f129aa0000825928b
😎 Deploy Preview https://deploy-preview-742--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahg-g
Copy link
Contributor

ahg-g commented Apr 25, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit ddc3d69 into kubernetes-sigs:main Apr 25, 2025
7 checks passed
shmuelk added a commit to shmuelk/gateway-api-inference-extension that referenced this pull request Apr 27, 2025
* main:
  fixing errors in new template & disabling the default blank template (kubernetes-sigs#742)
  Updating proposal directories to match their PR number (kubernetes-sigs#741)
  added a target dedicated for running unit-test only (kubernetes-sigs#739)
  Add unit tests for pod APIs under pkg/datastore (kubernetes-sigs#712)
  docs: add concepts and definitions to README.md (kubernetes-sigs#734)
  Update issue templates (kubernetes-sigs#738)
  Move filter and scorer plugins registration to a separate file (kubernetes-sigs#729)
  EPP: Update GetRandomPod() to return nil if no pods exist (kubernetes-sigs#731)
  filter irrelevant pod in pod_reconciler (kubernetes-sigs#696)
  scheduler refactoring (kubernetes-sigs#730)

# Conflicts:
#	pkg/epp/scheduling/plugins/picker.go
#	pkg/epp/scheduling/plugins/picker/random_picker.go
#	pkg/epp/scheduling/plugins/pickers/random.go
#	pkg/epp/scheduling/scheduler.go
#	pkg/epp/scheduling/scheduler_test.go
kaushikmitr pushed a commit to kaushikmitr/llm-instance-gateway that referenced this pull request Apr 28, 2025
rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants