added a target dedicated for running unit-test only #739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is very useful during development. Signed-off-by: Nir Rozenbaum <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ahg-g
reviewed
Apr 25, 2025
Makefile
Outdated
| @@ -123,8 +123,12 @@ vet: ## Run go vet against code. | |||
| test: manifests generate fmt vet envtest image-build ## Run tests. | |||
| KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" go test $$(go list ./... | grep -v /e2e) -race -coverprofile cover.out | |||
|
|
|||
| .PHONY: unit-test | |||
There was a problem hiding this comment.
nit: we used the pattern test- (see test-integration), so recommending to do the same here
Signed-off-by: Nir Rozenbaum <[email protected]>
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
shmuelk
added a commit
to shmuelk/gateway-api-inference-extension
that referenced
this pull request
Apr 27, 2025
* main: fixing errors in new template & disabling the default blank template (kubernetes-sigs#742) Updating proposal directories to match their PR number (kubernetes-sigs#741) added a target dedicated for running unit-test only (kubernetes-sigs#739) Add unit tests for pod APIs under pkg/datastore (kubernetes-sigs#712) docs: add concepts and definitions to README.md (kubernetes-sigs#734) Update issue templates (kubernetes-sigs#738) Move filter and scorer plugins registration to a separate file (kubernetes-sigs#729) EPP: Update GetRandomPod() to return nil if no pods exist (kubernetes-sigs#731) filter irrelevant pod in pod_reconciler (kubernetes-sigs#696) scheduler refactoring (kubernetes-sigs#730) # Conflicts: # pkg/epp/scheduling/plugins/picker.go # pkg/epp/scheduling/plugins/picker/random_picker.go # pkg/epp/scheduling/plugins/pickers/random.go # pkg/epp/scheduling/scheduler.go # pkg/epp/scheduling/scheduler_test.go
kaushikmitr
pushed a commit
to kaushikmitr/llm-instance-gateway
that referenced
this pull request
Apr 28, 2025
) * added a target dedicated for running unit-test only. this is very useful during development. Signed-off-by: Nir Rozenbaum <[email protected]> * code review Signed-off-by: Nir Rozenbaum <[email protected]> --------- Signed-off-by: Nir Rozenbaum <[email protected]>
kfswain
pushed a commit
to kfswain/llm-instance-gateway
that referenced
this pull request
Apr 29, 2025
) * added a target dedicated for running unit-test only. this is very useful during development. Signed-off-by: Nir Rozenbaum <[email protected]> * code review Signed-off-by: Nir Rozenbaum <[email protected]> --------- Signed-off-by: Nir Rozenbaum <[email protected]>
kfswain
pushed a commit
to kfswain/llm-instance-gateway
that referenced
this pull request
Apr 29, 2025
) * added a target dedicated for running unit-test only. this is very useful during development. Signed-off-by: Nir Rozenbaum <[email protected]> * code review Signed-off-by: Nir Rozenbaum <[email protected]> --------- Signed-off-by: Nir Rozenbaum <[email protected]>
kfswain
pushed a commit
to kfswain/llm-instance-gateway
that referenced
this pull request
Apr 29, 2025
) * added a target dedicated for running unit-test only. this is very useful during development. Signed-off-by: Nir Rozenbaum <[email protected]> * code review Signed-off-by: Nir Rozenbaum <[email protected]> --------- Signed-off-by: Nir Rozenbaum <[email protected]>
JeffLuoo
pushed a commit
to JeffLuoo/gateway-api-inference-extension
that referenced
this pull request
May 2, 2025
) * added a target dedicated for running unit-test only. this is very useful during development. Signed-off-by: Nir Rozenbaum <[email protected]> * code review Signed-off-by: Nir Rozenbaum <[email protected]> --------- Signed-off-by: Nir Rozenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is very useful during development