Add unit tests for pod APIs under pkg/datastore #712

rlakhtakia · 2025-04-18T20:50:58Z

No description provided.

k8s-ci-robot · 2025-04-18T20:51:07Z

Welcome @rlakhtakia!

It looks like this is your first PR to kubernetes-sigs/gateway-api-inference-extension 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api-inference-extension has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-04-18T20:51:08Z

Hi @rlakhtakia. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

netlify · 2025-04-18T20:51:20Z

✅ Deploy Preview for gateway-api-inference-extension ready!

Name	Link
🔨 Latest commit	`df39f48`
🔍 Latest deploy log	https://app.netlify.com/sites/gateway-api-inference-extension/deploys/680b1ebc149c220008baa0ca
😎 Deploy Preview	https://deploy-preview-712--gateway-api-inference-extension.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nirrozenbaum · 2025-04-19T20:40:01Z

pkg/epp/datastore/datastore_test.go

+			name:         "Add not ready pod, resync required, should update",
+			existingPods: []*corev1.Pod{pod1, notReadyPod},
+			wantPods:     []*corev1.Pod{pod1, pod2},
+			op: func(ctx context.Context, ds Datastore) {
+				scheme := runtime.NewScheme()
+				cfg := config.GetConfigOrDie()
+				cli, err := client.New(cfg, client.Options{Scheme: scheme})
+				if err != nil {
+					t.Fatalf("Unable to create ctrl runtime client")
+				}
+				ds.PodResyncAll(ctx, cli, pool)
+			},


pod resync is not required on pod not ready. it is required when inf pool label selector is changed.
generally, I've been working on datastore a bit (started refactoring, pushed a small PR and more to come),
IMO PodResyncAll should be removed from the interface.
having said that, the internal behavior is still there and is called upon a change in the pool label selector.
more details in the PR #713

nirrozenbaum · 2025-04-19T20:44:06Z

/ok-to-test

danehans · 2025-04-23T18:28:48Z

@rlakhtakia can you rebase when you have a moment?

* initial changes * Adding to proposal to give a quick barebones definition to refactor * feedback changes * more feedback addressing

Signed-off-by: Nir Rozenbaum <[email protected]>

This looks like a copy paste error.

* Refactor scheduler to run plugins * Add scheduler plugin latency metric * Address comments * Address comments

* Initial guide for inference pool * Add extensionReference to the InferencePool spec * Fix list formatting * Remove unused labels * Autogenerate the spec * Update site-src/api-types/inferencepool.md Co-authored-by: Rob Scott <[email protected]> * Update site-src/api-types/inferencepool.md Co-authored-by: Rob Scott <[email protected]> * Update site-src/api-types/inferencepool.md Co-authored-by: Rob Scott <[email protected]> * Update site-src/api-types/inferencepool.md Co-authored-by: Rob Scott <[email protected]> * Update site-src/api-types/inferencepool.md Co-authored-by: Rob Scott <[email protected]> * Update site-src/api-types/inferencepool.md Co-authored-by: Rob Scott <[email protected]> * Rename llm-pool names in rollout example * Add use cases for replacing an inference pool * Rewording the background section * Create replacing-inference-pool.md * Replace instructions with a link for how to replace an inference pool * Update replacing-inference-pool.md * Update mkdocs.yml * Update replacing-inference-pool.md * Update inferencemodel_types.go * Update inferencepool.md * Update site-src/guides/replacing-inference-pool.md Co-authored-by: Rob Scott <[email protected]> --------- Co-authored-by: Rob Scott <[email protected]>

…igs#708) * reduce log level in metrics logger not to trash the log Signed-off-by: Nir Rozenbaum <[email protected]> * rename flush metrics to refresh metrics Signed-off-by: Nir Rozenbaum <[email protected]> * revert log level Signed-off-by: Nir Rozenbaum <[email protected]> --------- Signed-off-by: Nir Rozenbaum <[email protected]>

* few updates in datastore Signed-off-by: Nir Rozenbaum <[email protected]> * PoolSet documentation Signed-off-by: Nir Rozenbaum <[email protected]> * error phrasing Signed-off-by: Nir Rozenbaum <[email protected]> * removed unused pool arg from PodUpdateOrAddIfNotExist Signed-off-by: Nir Rozenbaum <[email protected]> * linter Signed-off-by: Nir Rozenbaum <[email protected]> --------- Signed-off-by: Nir Rozenbaum <[email protected]>

Signed-off-by: Nir Rozenbaum <[email protected]>

…-sigs#731) Signed-off-by: Daneyon Hansen <[email protected]>

…netes-sigs#729) * Move filters and scorers registration to filter/scorer specific files * Default scheduler config contains empty list of scorers Signed-off-by: Maya Barnea <[email protected]> * Default plugin is not a scorer any more Signed-off-by: Maya Barnea <[email protected]> * fix scheduler test + lint comments Signed-off-by: Maya Barnea <[email protected]> --------- Signed-off-by: Maya Barnea <[email protected]>

* Update issue templates * Updates artifacts for v0.3.0-rc.1 release Signed-off-by: Kellen Swain <[email protected]> * Updates bbr chart for v0.3.0-rc.1 release Signed-off-by: Kellen Swain <[email protected]> * Updates artifacts for v0.3.0 release Signed-off-by: Kellen Swain <[email protected]> * Adding blank issue template so that all issues start with label --------- Signed-off-by: Kellen Swain <[email protected]>

* few updates in datastore Signed-off-by: Nir Rozenbaum <[email protected]> * PoolSet documentation Signed-off-by: Nir Rozenbaum <[email protected]> * error phrasing Signed-off-by: Nir Rozenbaum <[email protected]> * removed unused pool arg from PodUpdateOrAddIfNotExist Signed-off-by: Nir Rozenbaum <[email protected]> * linter Signed-off-by: Nir Rozenbaum <[email protected]> --------- Signed-off-by: Nir Rozenbaum <[email protected]>

…rence-extension

…-inference-extension

ahg-g · 2025-04-25T15:00:25Z

/lgtm
/approve

Thanks!

k8s-ci-robot · 2025-04-25T15:00:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, rlakhtakia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ahg-g]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rlakhtakia and others added 2 commits April 18, 2025 18:42

Add unit test coverage for pod APIs under datastore/pkg

256acf8

Merge branch 'kubernetes-sigs:main' into main

7b0d548

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 18, 2025

k8s-ci-robot requested review from kfswain and liu-cong April 18, 2025 20:51

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 18, 2025

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 18, 2025

nirrozenbaum reviewed Apr 19, 2025

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2025

rlakhtakia added 3 commits April 21, 2025 19:40

Add unit test coverage for pod APIs under datastore/pkg

0b7f537

Add unit test coverage for pod APIs under datastore/pkg

2ba431d

Add unit test coverage for pod APIs under datastore/pkg

5067fac

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2025

kfswain and others added 11 commits April 25, 2025 05:13

EPP Architecture proposal (kubernetes-sigs#683)

9b71677

* initial changes * Adding to proposal to give a quick barebones definition to refactor * feedback changes * more feedback addressing

removed unused Fake struct (kubernetes-sigs#723)

bfbc35f

Signed-off-by: Nir Rozenbaum <[email protected]>

epp: return correct response for trailers (kubernetes-sigs#726)

fc980b8

This looks like a copy paste error.

Refactor scheduler to run plugins (kubernetes-sigs#677)

55600b4

* Refactor scheduler to run plugins * Add scheduler plugin latency metric * Address comments * Address comments

scheduler refactoring (kubernetes-sigs#730)

d167e49

Signed-off-by: Nir Rozenbaum <[email protected]>

filter irrelevant pod in pod_reconciler (kubernetes-sigs#696)

c262a1d

EPP: Update GetRandomPod() to return nil if no pods exist (kubernetes…

4707ab2

…-sigs#731) Signed-off-by: Daneyon Hansen <[email protected]>

kfswain and others added 2 commits April 25, 2025 05:14

Add unit test coverage for pod APIs under datastore/pkg

f93cbe6

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 25, 2025

nirrozenbaum and others added 5 commits April 25, 2025 05:30

Add unit test coverage for pod APIs under datastore/pkg

124369e

Merge branch 'main' of https://github.com/rlakhtakia/gateway-api-infe…

44f424a

…rence-extension

Merge branch 'main' of https://github.com/kubernetes-sigs/gateway-api…

df39f48

…-inference-extension

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 25, 2025

k8s-ci-robot assigned ahg-g Apr 25, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add unit tests for pod APIs under pkg/datastore #712

Add unit tests for pod APIs under pkg/datastore #712

rlakhtakia commented Apr 18, 2025

k8s-ci-robot commented Apr 18, 2025

k8s-ci-robot commented Apr 18, 2025

netlify bot commented Apr 18, 2025 •

edited

Loading

nirrozenbaum Apr 19, 2025

nirrozenbaum commented Apr 19, 2025

danehans commented Apr 23, 2025

ahg-g commented Apr 25, 2025

k8s-ci-robot commented Apr 25, 2025

Add unit tests for pod APIs under pkg/datastore #712

Are you sure you want to change the base?

Add unit tests for pod APIs under pkg/datastore #712

Conversation

rlakhtakia commented Apr 18, 2025

k8s-ci-robot commented Apr 18, 2025

k8s-ci-robot commented Apr 18, 2025

netlify bot commented Apr 18, 2025 • edited Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

nirrozenbaum Apr 19, 2025

Choose a reason for hiding this comment

nirrozenbaum commented Apr 19, 2025

danehans commented Apr 23, 2025

ahg-g commented Apr 25, 2025

k8s-ci-robot commented Apr 25, 2025

netlify bot commented Apr 18, 2025 •

edited

Loading