-
Notifications
You must be signed in to change notification settings - Fork 269
🐛 fix: skip port deletion when instances have no port #1818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix: skip port deletion when instances have no port #1818
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This is a replacement for #1794. |
294b2d3
to
626c359
Compare
And I added a simple unit test covering this case too. |
/lgtm Note, I'll port that to the port refactor. |
well in fact I don't need to port that PR into #1788 because the ports management is now separated from instances. |
/approve I seems saw similar PR for same purpose recently but can't find where it is .. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What this PR does / why we need it:
This adds a condition in GarbageCollectErrorInstancesPort to avoid index outOfRange error when an instance has no port because of some reason (maybe the instance provisioning failed because of infra issue).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1805
Special notes for your reviewer:
TODOs:
/hold