-
Notifications
You must be signed in to change notification settings - Fork 269
fix: skip port deletion when instances have no port #1794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @okozachenko1203. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mnaser, okozachenko1203 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
can you help create an issue for this @okozachenko1203 ? the change lgtm I knew we have various case VM deploy failed and port not created |
/lgtm The request to create the issue stands. |
done #1805 |
@okozachenko1203 is this close on purpose? seems it's triggered by some CI ?? |
I will reopen first |
/reopen |
@dulek: Failed to re-open PR: state cannot be changed. The repository that submitted this pull request has been deleted. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'm going to put this into a new PR. |
fix #1805
What this PR does / why we need it:
This adds a condition in
GarbageCollectErrorInstancesPort
to avoidindex outOfRange
error when an instance has no port because of some reason (maybe the instance provisioning failed because of infra issue).Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
/hold