Skip to content

fix: skip port deletion when instances have no port #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: skip port deletion when instances have no port #1794

wants to merge 1 commit into from

Conversation

okozachenko1203
Copy link
Contributor

@okozachenko1203 okozachenko1203 commented Dec 18, 2023

fix #1805
What this PR does / why we need it:
This adds a condition in GarbageCollectErrorInstancesPort to avoid index outOfRange error when an instance has no port because of some reason (maybe the instance provisioning failed because of infra issue).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2023
Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 294b2d3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65805257e9f4060008eae620
😎 Deploy Preview https://deploy-preview-1794--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 18, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 18, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @okozachenko1203. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mnaser, okozachenko1203
Once this PR has been reviewed and has the lgtm label, please assign cecilerobertmichon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jichenjc
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 21, 2023
@jichenjc
Copy link
Contributor

can you help create an issue for this @okozachenko1203 ? the change lgtm

I knew we have various case VM deploy failed and port not created
but seems not report this issue before ..

@dulek
Copy link
Contributor

dulek commented Dec 22, 2023

/lgtm

The request to create the issue stands.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2023
@okozachenko1203
Copy link
Contributor Author

okozachenko1203 commented Dec 28, 2023

can you help create an issue for this @okozachenko1203 ? the change lgtm

I knew we have various case VM deploy failed and port not created but seems not report this issue before ..

done #1805

@vexxhost vexxhost closed this by deleting the head repository Jan 4, 2024
@jichenjc
Copy link
Contributor

jichenjc commented Jan 4, 2024

@okozachenko1203 is this close on purpose? seems it's triggered by some CI ??

@jichenjc
Copy link
Contributor

jichenjc commented Jan 4, 2024

I will reopen first

@dulek
Copy link
Contributor

dulek commented Jan 10, 2024

/reopen

@k8s-ci-robot
Copy link
Contributor

@dulek: Failed to re-open PR: state cannot be changed. The repository that submitted this pull request has been deleted.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link
Contributor

dulek commented Jan 10, 2024

I'm going to put this into a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: failed instances with no port breaks the whole CAPO controller
6 participants