Merge pull request #1818 from dulek/skip-port-delete-no-port

🐛 fix: skip port deletion when instances have no port

Author: k8s-ci-robot

pkg/cloud/services/networking/port.go

@@ -315,6 +315,10 @@ func (s *Service) GarbageCollectErrorInstancesPort(eventObject runtime.Object, i
 			return fmt.Errorf("garbage collection of port %s failed, found %d ports with the same name", portName, len(portList))
 		}
 
+		if len(portList) == 0 {
+			continue
+		}
+
 		if err := s.DeletePort(eventObject, portList[0].ID); err != nil {
 			return err
 		}

pkg/cloud/services/networking/port_test.go

@@ -588,6 +588,19 @@ func Test_GarbageCollectErrorInstancesPort(t *testing.T) {
 				{},
 			},
 			wantErr: false,
+		}, {
+			name: "garbage collects no ports in an instance",
+			expect: func(m *mock.MockNetworkClientMockRecorder) {
+				o1 := ports.ListOpts{
+					Name: portName1,
+				}
+				p1 := []ports.Port{}
+				m.ListPort(o1).Return(p1, nil)
+			},
+			portOpts: []infrav1.PortOpts{
+				{},
+			},
+			wantErr: false,
 		},
 	}