Skip to content

urllib3 1.21 fails kubernetes if you use configuration.assert_hostname #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mbohlool opened this issue Apr 25, 2017 · 2 comments · Fixed by #203
Closed

urllib3 1.21 fails kubernetes if you use configuration.assert_hostname #197

mbohlool opened this issue Apr 25, 2017 · 2 comments · Fixed by #203
Assignees
@mbohlool
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mbohlool
Copy link
Contributor

Look like the new version of urlib3 fails out tests:

logs: https://travis-ci.org/kubernetes-incubator/client-python/jobs/225699267
@mbohlool mbohlool added the kind/bug Categorizes issue or PR as related to a bug. label Apr 25, 2017
@mbohlool mbohlool self-assigned this Apr 25, 2017
@mbohlool
Copy link
Contributor Author

cc @dims

@mbohlool mbohlool mentioned this issue Apr 25, 2017
Merged
@mbohlool
Copy link
Contributor Author

The change is urllib3 is explained in this issue: urllib3/urllib3#1016

This was referenced Apr 26, 2017
Closed
Merged
@mbohlool mbohlool changed the title urllib3 >1.20 fails kubernetes if you use configuration.assert_hostname urllib3 1.20 fails kubernetes if you use configuration.assert_hostname Apr 26, 2017
mbohlool added a commit that referenced this issue Apr 26, 2017
@mbohlool
Exclude urllib3 version 1.21 from dependencies #197
eb418d2
@mbohlool mbohlool changed the title urllib3 1.20 fails kubernetes if you use configuration.assert_hostname urllib3 1.21 fails kubernetes if you use configuration.assert_hostname Apr 26, 2017
@withsmilo withsmilo mentioned this issue Nov 28, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbohlool mbohlool

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude urllib3 version 1.21 from depedencies as it breaks our code mbohlool/client-python
1 participant
@mbohlool