Exclude urllib3 version 1.21 from depedencies as it breaks our code #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
actually this should be a patch after being merged to master. closing this. |
Codecov Report
@@ Coverage Diff @@
## release-1.0 #202 +/- ##
============================================
Coverage 94.46% 94.46%
============================================
Files 9 9
Lines 668 668
============================================
Hits 631 631
Misses 37 37Continue to review full report at Codecov.
|
yliaog
pushed a commit
to yliaog/client-python
that referenced
this pull request
Jan 8, 2022
Add old api_key to set auth attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #197
Look like the problem is going away after 1.21 because of this patch: urllib3/urllib3#1157
so we should be fine with versions > 1.21