Skip to content

Depend on urllib3 version <= 1.20 #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2017
Merged

Conversation

mbohlool
Copy link
Contributor

New version of urllib3 is failing our tests and probably some users.

ref #197

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 25, 2017
@dims
Copy link
Collaborator

dims commented Apr 25, 2017

LGTM

@mbohlool mbohlool merged commit 2d06710 into kubernetes-client:master Apr 25, 2017
@codecov-io
Copy link

Codecov Report

Merging #198 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   94.56%   94.56%           
=======================================
  Files           9        9           
  Lines         681      681           
=======================================
  Hits          644      644           
  Misses         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a190dd...bc33850. Read the comment docs.

@dims
Copy link
Collaborator

dims commented Apr 25, 2017

Filed a patch against urllib3 https://github.com/shazow/urllib3/pull/1157/commits

yliaog pushed a commit to yliaog/client-python that referenced this pull request Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants