Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Runs hack/* scripts as individual build step #172

Conversation

palnabarun
Copy link
Member

The verify boilerplate script was being run on every test run. That is being changed in this PR to run the verify boilerplate script as a separate CI stage.

Fixes #118

Reference: Traves CI Build Stages

@k8s-ci-robot
Copy link
Contributor

Welcome @palnabarun!

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python-base has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 20, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 20, 2019
@palnabarun
Copy link
Member Author

/assign @roycaihw @micw523

@codecov-io
Copy link

Codecov Report

Merging #172 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #172   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files          13       13           
  Lines        1398     1398           
=======================================
  Hits         1306     1306           
  Misses         92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b65461...5f395ba. Read the comment docs.

@micw523
Copy link
Contributor

micw523 commented Oct 21, 2019

/lgtm
This looks good to me - could I ask you to send in a PR looking like kubernetes-client/python#970 too?

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2019
@palnabarun
Copy link
Member Author

@micw523 Sure. Filing a PR for adding Python 3.8 to the test matrix.

@palnabarun
Copy link
Member Author

@micw523 Filed #173 to add Python 3.8 to the test matrix.

@roycaihw
Copy link
Member

/assign

@roycaihw
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: palnabarun, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 51157aa into kubernetes-client:master Oct 22, 2019
@palnabarun palnabarun deleted the 118-ci-boilerplate-seperation branch October 22, 2019 18:20
@palnabarun
Copy link
Member Author

Thank you @micw523 @roycaihw :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run hack/ as an individual CI test
5 participants