Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Run hack/ as an individual CI test #118

Closed
micw523 opened this issue Feb 20, 2019 · 10 comments · Fixed by #172
Closed

Run hack/ as an individual CI test #118

micw523 opened this issue Feb 20, 2019 · 10 comments · Fixed by #172
Assignees
@palnabarun
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@micw523
Copy link
Contributor

micw523 commented Feb 20, 2019 •
edited
Loading

Currently the hack/ scripts are run as part of all of CI tests. An example can be seen here.

Instead, we should move the hack/ scripts to an additional individual check. This saves us some build time for CI and also allows us to potentially expand the scope of hack/ checks we can do in the future. As a background, see kubernetes-client/python#22
@micw523
Copy link
Contributor Author

micw523 commented Feb 20, 2019

/priority backlog
/good-first-issue
/help

@k8s-ci-robot
Copy link
Contributor

@micw523:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/priority backlog
/good-first-issue
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 20, 2019
@Sai-Adarsh
Copy link

Sai-Adarsh commented Mar 5, 2019 •
edited
Loading

Currently the hack/ scripts are run as part of all of CI tests. An example can be seen here.

Instead, we should move the hack/ scripts to an additional individual check. This saves us some build time for CI and also allows us to potentially expand the scope of hack/ checks we can do in the future. As a background, see kubernetes-client/python#22

Hey @micw523 I'm interested with this, What do you mean by 'Additional individual check' and need some more pointers on how to fix this issue?

@micw523
Copy link
Contributor Author

micw523 commented Mar 14, 2019

I just saw this. Have you checked one of the Travis CI’s build interface? You’ll see one if you go to any PR and click on the details next to the Travis CI build status.

You’ll see many individual tests in it. The goal is to write another test for the hack/ scripts instead of hard coding it into every test in .travis.yml.

@micw523 micw523 mentioned this issue Mar 25, 2019
Closed
@micw523
Copy link
Contributor Author

micw523 commented Mar 25, 2019

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Mar 25, 2019
@micw523
Copy link
Contributor Author

micw523 commented Mar 25, 2019

/remove-priority backlog

@k8s-ci-robot k8s-ci-robot removed the priority/backlog Higher priority than priority/awaiting-more-evidence. label Mar 25, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 23, 2019
@micw523
Copy link
Contributor Author

micw523 commented Jun 25, 2019

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 25, 2019
@roycaihw
Copy link
Member

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Aug 13, 2019
@scottilee scottilee mentioned this issue Aug 20, 2019
Closed
@palnabarun palnabarun mentioned this issue Oct 20, 2019
Merged
@palnabarun
Copy link
Member

/assign

@palnabarun palnabarun mentioned this issue Nov 25, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@palnabarun palnabarun

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Runs hack/* scripts as individual build step palnabarun/python-base
6 participants
@roycaihw @palnabarun @micw523 @k8s-ci-robot @Sai-Adarsh @fejta-bot