Enable testing for Python 3.8 #970

Jamim · 2019-09-25T21:49:32Z

Hello,

Python 3.8 is almost there, so I believe that it would be nice to have tests for it on CI.

Best regards!

k8s-ci-robot · 2019-09-25T21:49:33Z

Welcome @Jamim!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

yliaog · 2019-09-25T22:00:18Z

3.8.0 final: Monday, 2019-10-21

we want to merge this after that, right?

Jamim · 2019-09-25T22:17:53Z

Hello @yliaog,
I believe it makes sense to merge it now in order to be aware in case something became broken for 3.8 due to some changes.

micw523 · 2019-09-25T22:52:09Z

/hold
Even though Python 3.8 will be here soon, Travis CI will probably be ready much later. Therefore there’s no rush getting this PR in since we’ll have to wait.

micw523

I appreciate the cleanup of the CI script, but we’d be better off waiting on Travis CI side.

micw523 · 2019-09-25T22:52:54Z

.travis.yml

@@ -28,6 +28,10 @@ matrix:
       env: TOXENV=py37
     - python: 3.7
       env: TOXENV=py37-functional
+     - python: 3.8-dev


3.8-dev is still a development build and is not ready for production yet.

But it's good enough for testing purposes.

The reason we want to test a certain version is that we’ll be confident supporting this version in PyPI wheels. Therefore, I would stick to stable release only.

Jamim · 2019-09-25T22:54:54Z

In fact, Travis CI is ready.
Please take a look at the corresponding build.

micw523 · 2019-09-25T22:56:40Z

Yet, 3.8 dev is not 3.8 final. Also, I don’t know how I selected approve for this PR - I meant “comment”.

Jamim · 2019-09-25T23:02:30Z

https://pythoninsider.blogspot.com/2019/08/python-380b4-is-now-available-for.html

We strongly encourage maintainers of third-party Python projects to test with 3.8 during the beta phase and report issues found to the Python bug tracker as soon as possible. Please note this is the last beta release, there is not much time left to identify and fix issues before the release of 3.8.0. If you were hesitating trying it out before, now is the time.

micw523 · 2019-09-27T21:30:31Z

https://pythoninsider.blogspot.com/2019/08/python-380b4-is-now-available-for.html

Please keep in mind that this is a preview release and its use is not recommended for production environments.

Please do notice that this repo is used in production environments. We won't be confident in supporting Python 3.8 unless it's production ready.

micw523 · 2019-10-14T21:28:55Z

/hold cancel
Please update the environment to 3.8 stable and we'll see from there

Jamim · 2019-10-14T23:43:16Z

Hello @micw523,
3.8 is not available on Travis CI yet.
Currently, there is 3.8-dev only.

Python 3.8 is there, so I believe that it would be nice to declare support and add tests for it on CI. Python 3.8.0 release announcement: https://discuss.python.org/t/python-3-8-0-is-now-available/2478

Jamim · 2019-10-16T21:14:54Z

Hi @micw523,
I believe this PR is ready to be merged now.

micw523 · 2019-10-16T21:19:09Z

/lgtm
/cc @roycaihw
/assign @roycaihw
This looks good to me.

micw523 · 2019-10-16T21:21:26Z

setup.py

@@ -77,5 +77,6 @@
        "Programming Language :: Python :: 3.5",
        "Programming Language :: Python :: 3.6",
        "Programming Language :: Python :: 3.7",
+        "Programming Language :: Python :: 3.8",


As a side note, we'll need py38 wheels in the next release possibly.

yliaog · 2019-10-16T22:16:36Z

/approve

k8s-ci-robot · 2019-10-16T22:16:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jamim, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [yliaog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 25, 2019

k8s-ci-robot requested review from roycaihw and yliaog September 25, 2019 21:49

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 25, 2019

roycaihw requested a review from micw523 September 25, 2019 21:53

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2019

micw523 approved these changes Sep 25, 2019

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2019

Enable testing for Python 3.8

4d85892

Python 3.8 is there, so I believe that it would be nice to declare support and add tests for it on CI. Python 3.8.0 release announcement: https://discuss.python.org/t/python-3-8-0-is-now-available/2478

Jamim force-pushed the feature/python3.8-tests branch from 1b2b09c to 4d85892 Compare October 16, 2019 21:01

k8s-ci-robot assigned roycaihw and micw523 Oct 16, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2019

micw523 reviewed Oct 16, 2019

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2019

k8s-ci-robot merged commit ca4f311 into kubernetes-client:master Oct 16, 2019

Jamim deleted the feature/python3.8-tests branch October 16, 2019 22:29

micw523 mentioned this pull request Oct 21, 2019

Runs hack/* scripts as individual build step kubernetes-client/python-base#172

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable testing for Python 3.8 #970

Enable testing for Python 3.8 #970

Jamim commented Sep 25, 2019

k8s-ci-robot commented Sep 25, 2019

yliaog commented Sep 25, 2019

Jamim commented Sep 25, 2019

micw523 commented Sep 25, 2019

micw523 left a comment

micw523 Sep 25, 2019

Jamim Sep 25, 2019

micw523 Sep 25, 2019

Jamim commented Sep 25, 2019

micw523 commented Sep 25, 2019

Jamim commented Sep 25, 2019

micw523 commented Sep 27, 2019

micw523 commented Oct 14, 2019

Jamim commented Oct 14, 2019

Jamim commented Oct 16, 2019

micw523 commented Oct 16, 2019

micw523 Oct 16, 2019

yliaog commented Oct 16, 2019

k8s-ci-robot commented Oct 16, 2019

Enable testing for Python 3.8 #970

Enable testing for Python 3.8 #970

Conversation

Jamim commented Sep 25, 2019

k8s-ci-robot commented Sep 25, 2019

yliaog commented Sep 25, 2019

Jamim commented Sep 25, 2019

micw523 commented Sep 25, 2019

micw523 left a comment

Choose a reason for hiding this comment

micw523 Sep 25, 2019

Choose a reason for hiding this comment

Jamim Sep 25, 2019

Choose a reason for hiding this comment

micw523 Sep 25, 2019

Choose a reason for hiding this comment

Jamim commented Sep 25, 2019

micw523 commented Sep 25, 2019

Jamim commented Sep 25, 2019

micw523 commented Sep 27, 2019

micw523 commented Oct 14, 2019

Jamim commented Oct 14, 2019

Jamim commented Oct 16, 2019

micw523 commented Oct 16, 2019

micw523 Oct 16, 2019

Choose a reason for hiding this comment

yliaog commented Oct 16, 2019

k8s-ci-robot commented Oct 16, 2019