Skip to content

Removed pymysql.util function ( byte2int, int2byte ) #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jongwony
Copy link

byte2int, int2byte removed at PyMySQL>=1.0.0 in pymysql.util

https://github.com/PyMySQL/PyMySQL/pull/923/files

@julien-duponchelle
Copy link
Owner

Hello,

Thanks a lot for the contribution. Did you manage to run the tests because it's all red on travis ? https://travis-ci.org/github/noplay/python-mysql-replication/builds/754423590

(by the way I need to fix the travist integration it should have post the test result here sorry)

@jongwony
Copy link
Author

I tested it by referring to the documentation.

While modifying the code, I didn't consider the python 2 version.

I tried the test but the test did not finish successfully. I need your help.

mac OS(Big Sur)
python3.8

setup virtual environment 3.8

python -v venv venv
. venv/bin/activate
python setup.py install
pip install pytest

Running mysql in docker (main):

docker run --name python-mysql-replication-tests -e MYSQL_ALLOW_EMPTY_PASSWORD=true -p 3306:3306 --rm percona:latest --log-bin=mysql-bin.log --server-id 1 --binlog-format=row --gtid_mode=on --enforce-gtid-consistency=on --log_slave_updates

Run test with:

py.test -k "not test_no_trailing_rotate_event"

Docker log:

[Note] Start binlog_dump to master_thread_id(6) slave_server(1024), pos(mysql-bin.000001, 4)

py.test log:

================================= test session starts ==================================
platform darwin -- Python 3.8.5, pytest-6.2.2, py-1.10.0, pluggy-0.13.1
rootdir: /Users/jongwon/Documents/github/clone/python-mysql-replication
collected 95 items / 1 deselected / 94 selected

pymysqlreplication/tests/test_basic.py .

After going so far, the test was stuck.

@leviathan-litan
Copy link

This is very useful.

@mouday
Copy link

mouday commented Mar 22, 2021

this bug no handler?

@jongwony
Copy link
Author

jongwony commented Sep 6, 2021

Fixed #348 Thank you!

@jongwony jongwony closed this Sep 6, 2021
TheAMM pushed a commit to nyaadevs/nyaa that referenced this pull request Jun 4, 2022
upgrade dependencies and fix some things which broke
mysql fulltextsearch module doesn't work but nobody uses that

PyMySQL not upgraded due to
julien-duponchelle/python-mysql-replication#337

ES not really tested as always xd (I need to make a proper dev setup)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants