Add pymysql 1.0 support #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pymysql>=1.0 removed pymysql.util. PyMySQL/PyMySQL#923 replaced bytes2int, int2byte in py23 compatible manner.
|
#91 is related in |
|
Thanks you so much release is in progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pymysql>=1.0 removed pymysql.util.
PyMySQL/PyMySQL#923
replaced bytes2int, int2byte in py23 compatible manner.
There is #337 that aims to fix the same issue.
Another patch is #346 for int2byte part.
Tested
setup.py testwith docker percona instances as in docs.