Skip to content

Removed pymysql.util function ( byte2int, int2byte ) #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions pymysqlreplication/binlogstream.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

from pymysql.constants.COMMAND import COM_BINLOG_DUMP, COM_REGISTER_SLAVE
from pymysql.cursors import DictCursor
from pymysql.util import int2byte

from .packet import BinLogPacketWrapper
from .constants.BINLOG import TABLE_MAP_EVENT, ROTATE_EVENT
Expand Down Expand Up @@ -109,7 +108,7 @@ def encoded(self, server_id, master_id=0):
MAX_STRING_LEN = 257 # one byte for length + 256 chars

return (struct.pack('<i', packet_len) +
int2byte(COM_REGISTER_SLAVE) +
bytes([COM_REGISTER_SLAVE]) +
struct.pack('<L', server_id) +
struct.pack('<%dp' % min(MAX_STRING_LEN, lhostname + 1),
self.hostname.encode()) +
Expand Down Expand Up @@ -321,7 +320,7 @@ def __connect_to_stream(self):
cur.close()

prelude = struct.pack('<i', len(self.log_file) + 11) \
+ int2byte(COM_BINLOG_DUMP)
+ bytes([COM_BINLOG_DUMP])

if self.__resume_stream:
prelude += struct.pack('<I', self.log_pos)
Expand Down Expand Up @@ -382,7 +381,7 @@ def __connect_to_stream(self):
4) # encoded_data_size

prelude = b'' + struct.pack('<i', header_size + encoded_data_size)\
+ int2byte(COM_BINLOG_DUMP_GTID)
+ bytes([COM_BINLOG_DUMP_GTID])

flags = 0
if not self.__blocking:
Expand Down
8 changes: 3 additions & 5 deletions pymysqlreplication/event.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
import struct
import datetime

from pymysql.util import byte2int, int2byte


class BinLogEvent(object):
def __init__(self, from_packet, event_size, table_map, ctl_connection,
Expand All @@ -30,7 +28,7 @@ def __init__(self, from_packet, event_size, table_map, ctl_connection,
def _read_table_id(self):
# Table ID is 6 byte
# pad little-endian number
table_id = self.packet.read(6) + int2byte(0) + int2byte(0)
table_id = self.packet.read(6) + b'\0' + b'\0'
return struct.unpack('<Q', table_id)[0]

def dump(self):
Expand All @@ -55,7 +53,7 @@ def __init__(self, from_packet, event_size, table_map, ctl_connection, **kwargs)
super(GtidEvent, self).__init__(from_packet, event_size, table_map,
ctl_connection, **kwargs)

self.commit_flag = byte2int(self.packet.read(1)) == 1
self.commit_flag = self.packet.read(1)[0] == 1
self.sid = self.packet.read(16)
self.gno = struct.unpack('<Q', self.packet.read(8))[0]

Expand Down Expand Up @@ -164,7 +162,7 @@ def __init__(self, from_packet, event_size, table_map, ctl_connection, **kwargs)
# Post-header
self.slave_proxy_id = self.packet.read_uint32()
self.execution_time = self.packet.read_uint32()
self.schema_length = byte2int(self.packet.read(1))
self.schema_length = self.packet.read(1)[0]
self.error_code = self.packet.read_uint16()
self.status_vars_length = self.packet.read_uint16()

Expand Down
8 changes: 3 additions & 5 deletions pymysqlreplication/packet.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

import struct

from pymysql.util import byte2int

from pymysqlreplication import constants, event, row_event

# Constants from PyMYSQL source code
Expand Down Expand Up @@ -111,7 +109,7 @@ def __init__(self, from_packet, table_map, ctl_connection, use_checksum,

# Header
self.timestamp = unpack[1]
self.event_type = byte2int(unpack[2])
self.event_type = unpack[2]
self.server_id = unpack[3]
self.event_size = unpack[4]
# position of the next event
Expand Down Expand Up @@ -178,7 +176,7 @@ def read_length_coded_binary(self):

From PyMYSQL source code
"""
c = byte2int(self.read(1))
c = self.read(1)[0]
if c == NULL_COLUMN:
return None
if c < UNSIGNED_CHAR_COLUMN:
Expand Down Expand Up @@ -263,7 +261,7 @@ def read_variable_length_string(self):
length = 0
bits_read = 0
while byte & 0x80 != 0:
byte = byte2int(self.read(1))
byte = self.read(1)[0]
length = length | ((byte & 0x7f) << bits_read)
bits_read = bits_read + 7
return self.read(length)
Expand Down
7 changes: 3 additions & 4 deletions pymysqlreplication/row_event.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import datetime
import json

from pymysql.util import byte2int
from pymysql.charset import charset_by_name

from .event import BinLogEvent
Expand Down Expand Up @@ -556,10 +555,10 @@ def __init__(self, from_packet, event_size, table_map, ctl_connection, **kwargs)
self.flags = struct.unpack('<H', self.packet.read(2))[0]

# Payload
self.schema_length = byte2int(self.packet.read(1))
self.schema_length = self.packet.read(1)[0]
self.schema = self.packet.read(self.schema_length).decode()
self.packet.advance(1)
self.table_length = byte2int(self.packet.read(1))
self.table_length = self.packet.read(1)[0]
self.table = self.packet.read(self.table_length).decode()

if self.__only_tables is not None and self.table not in self.__only_tables:
Expand Down Expand Up @@ -617,7 +616,7 @@ def __init__(self, from_packet, event_size, table_map, ctl_connection, **kwargs)
'COLUMN_TYPE': 'BLOB', # we don't know what it is, so let's not do anything with it.
'COLUMN_KEY': '',
}
col = Column(byte2int(column_type), column_schema, from_packet)
col = Column(column_type, column_schema, from_packet)
self.columns.append(col)

self.table_obj = Table(self.column_schemas, self.table_id, self.schema,
Expand Down
3 changes: 1 addition & 2 deletions pymysqlreplication/tests/binlogfilereader.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
'''Read binlog files'''
import struct

from pymysql.util import byte2int
from pymysqlreplication import constants
from pymysqlreplication.event import FormatDescriptionEvent
from pymysqlreplication.event import QueryEvent
Expand Down Expand Up @@ -113,7 +112,7 @@ def __init__(self, header):
'''Initialize the Event with the event header'''
unpacked = struct.unpack('<IcIIIH', header)
self.timestamp = unpacked[0]
self.event_type = byte2int(unpacked[1])
self.event_type = unpacked[1][0]
self.server_id = unpacked[2]
self.event_size = unpacked[3]
self.log_pos = unpacked[4]
Expand Down