Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Convert the software page from HTML to Markdown #84

Merged
merged 2 commits into from
Mar 23, 2017

Conversation

adamvoss
Copy link
Contributor

Somewhat ironically (given that nearly every link on the software page has an id) there was no anchor on a heading I wished to link to. Kramdown automatically generates anchors on headings, so making the page markdown resolved my issue and better utilizes Jekyll functionally.

I made sure to keep all the existing link ids or this would be have less HTML, new things can be added with markdown now if desired. Output looks the same. There are some structural differences (ex, initial text not in block) that did not affect rendering that I did not see a reason to preserve.

This also fixes a minor bug where the Dart link was pointing to Clojure.

It looked like this site was converted from PHP/HTML to Jekyll which explains why this was HTML and not markdown and why I thought conversion to Markdown might be acceptable. pandoc assisted with the conversion.

@Relequestual
Copy link
Member

Thanks for your effort on this @vossad01 - Looks like a neat change. I had no idea we could interlace MD and HTML through Jekyll.

Realistically, this is probably going to sit for a while before I have time to review it. If you enable github pages on your fork, I should be able to preview the changes without having to checkout locally and actually work out my build process (which I haven't done yet).

if you're able to do that, please let me know, and I'll take a look as soon as I can. =]

@adamvoss
Copy link
Contributor Author

adamvoss commented Mar 20, 2017

Done: https://vossad01.github.io/json-schema-org.github.io/
I even remembered to push the relevant commits to my master branch so you wouldn't just be looking at the current website (🙃 I almost for forgot this).

@Relequestual
Copy link
Member

Relequestual commented Mar 20, 2017

Super! Thanks. Hopefully I'll be able to confirm and merge this on... probably Thursday. Crazy busy right now =/

I mean at a glance this looks fine, but due diligence and all that =]

@Relequestual Relequestual merged commit 6b5a367 into json-schema-org:master Mar 23, 2017
@Relequestual
Copy link
Member

@vossad01 Thanks for doing this.
I think things will be FAR more manageable in MD than HTML.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants