-
-
Notifications
You must be signed in to change notification settings - Fork 213
Conversation
This way they work from both GitHub and the website.
7b9e693
to
f46e665
Compare
@vossad01 I'm finally trying to look at this and get jekyll running locally so I can look at this and #85. After installing ruby 2.4 and bundler, and checking out this branch from your fork, I'm getting the following errors: detective-eye:json-schema-org.github.io handrews$ git log --decorate HEAD^..HEAD
* commit f46e6655b761dba0742f8a1bc95aba7bc8a83276 (HEAD -> bundler, vossad/bundler)
Author: Adam Voss <[email protected]>
Date: Thu Mar 23 14:57:07 2017 -0500
Manage dependencies with bundler
detective-eye:json-schema-org.github.io handrews$ bundle exec jekyll serve
Configuration file: /Users/handrews/src/json-schema-org.github.io/_config.yml
Configuration file: /Users/handrews/src/json-schema-org.github.io/_config.yml
Source: /Users/handrews/src/json-schema-org.github.io
Destination: /Users/handrews/src/json-schema-org.github.io/_site
Incremental build: disabled. Enable with --incremental
Generating...
Conversion error: Jekyll::Converters::Scss encountered an error while converting 'assets/main.scss':
Undefined mixin 'relative-font-size'. on line 123
jekyll 3.4.3 | Error: Undefined mixin 'relative-font-size'. on line 123
detective-eye:json-schema-org.github.io handrews$ I assume you don't see this error- any ideas? (also, if you could rebase these PRs onto current master that would be awesome) I'm terribly sorry for the delay, both Relequestual and I have had different things distracting us recently. |
This was caused by an compatibility with the latest Minima gem which was released after this was submitted. I restricted it to the version this was developed against and it should work now. While I have a fix for working against the latest Gem, it should be tested which I don't have time for right now.
At this request, I have brought #85 fully up-to-date with Thanks! |
Thanks for reworking this so quickly, and my apologies again for the delay! |
@vossad01 apparently this is not building, although it built fine for me :-/
My CSS knowledge is so out-of-date that it pre-dates SCSS, and that file is only 48 lines long so I'm a bit puzzled here. I can try to debug it tomorrow but if you have any pointers please let me know. |
@handrews the I really cannot explain why you would receive this error. The obvious explanation would be that GitHub pages does not respect the Rather than figuring out what oddity caused it to still build against the old gem, you could accept #99 to just update to the latest. |
NOTE: this is built on #85 so the diff from that will also show here until it is merged. What this does:
bundle exec jekyll serve
, works to host the site. This also eliminates the need to manually install dependencies (beyond Ruby/Bundler) locally in order to build.This was done in reaction to some recent comments concerning the process of building the site locally. However, I ended up making this a non-minimal set of changes, including some other things I noticed in the process, to (hopefully) reduce overall review time. These commits can be isolated/separated, if that is preferred.