Skip to content

Fix E2E runtime - pin Firebase Tools, node 18 runtime #7865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 12, 2023
Merged

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Dec 12, 2023

Discussion

Updates to our E2E tests in CI (E2E Smoke Tests and Deploy Project Config) to use Node v18. Additionally, pin the firebase-tools version to 12.9.1. While we plan to upgrade the firebase-tools version in the future, we're chosing to pin to a version for the long term to prevent suddent CI test failures.

Testing

Executed a E2E test in CI.

API Changes

N/A.

Copy link

changeset-bot bot commented Dec 12, 2023

⚠️ No Changeset found

Latest commit: 965ba49

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DellaBitta DellaBitta requested a review from hsubox76 December 12, 2023 20:54
@DellaBitta DellaBitta marked this pull request as ready for review December 12, 2023 20:54
@DellaBitta DellaBitta requested a review from a team as a code owner December 12, 2023 20:54
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 12, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 12, 2023

@DellaBitta DellaBitta merged commit 15addde into master Dec 12, 2023
@DellaBitta DellaBitta deleted the ddb-e2e-node18 branch December 12, 2023 21:27
@firebase firebase locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants