Skip to content

Commit 15addde

Browse files
authored
Fix E2E runtime - pin Firebase Tools, node 18 runtime (#7865)
Updates to our E2E tests in CI (`E2E Smoke Tests` and `Deploy Project Config`) to use Node v18. Additionally, pin the firebase-tools version to 12.9.1. While we plan to upgrade the firebase-tools version in the future, we're chosing to pin to a version for the long term to prevent suddent CI test failures.
1 parent 42bfb0b commit 15addde

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

.github/workflows/deploy-config.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@ jobs:
3434
with:
3535
# This makes Actions fetch all Git history so run-changed script can diff properly.
3636
fetch-depth: 0
37-
- name: Set up node (16)
37+
- name: Set up node (18)
3838
uses: actions/setup-node@v3
3939
with:
40-
node-version: 16.x
40+
node-version: 18.x
4141
- name: Yarn install
4242
run: yarn
4343
- name: Deploy project config if needed

.github/workflows/e2e-test.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@ jobs:
3636
steps:
3737
- name: Checkout Repo
3838
uses: actions/checkout@master
39-
- name: Set up Node (16)
39+
- name: Set up Node (18)
4040
uses: actions/setup-node@master
4141
with:
42-
node-version: 16.x
42+
node-version: 18.x
4343
- name: install Chrome stable
4444
run: |
4545
sudo apt-get update
@@ -60,7 +60,7 @@ jobs:
6060
pushd functions
6161
npm install
6262
popd
63-
npx firebase-tools deploy --only functions:callTest --project jscore-sandbox-141b5 --token $FIREBASE_CLI_TOKEN
63+
npx firebase-tools@12.9.1 deploy --only functions:callTest --project jscore-sandbox-141b5 --token $FIREBASE_CLI_TOKEN
6464
working-directory: ./config
6565
env:
6666
FIREBASE_CLI_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}

0 commit comments

Comments
 (0)