Skip to content

Fix E2E runtime - pin Firebase Tools, node 18 runtime #7865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 12, 2023
Merged

Fix E2E runtime - pin Firebase Tools, node 18 runtime #7865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
386860d
update to node 18, run on push
DellaBitta Dec 12, 2023
812be13
update engines to great than 16
DellaBitta Dec 12, 2023
5a4b6c9
18
DellaBitta Dec 12, 2023
66848c2
functions engines >16, deploy-config workflow node 18
DellaBitta Dec 12, 2023
f9384a3
attempt to use an older version of firebase-tools
DellaBitta Dec 12, 2023
946d1c0
engines 16
DellaBitta Dec 12, 2023
c4077c3
use firebase tools 13.0.0
DellaBitta Dec 12, 2023
72096a3
use firebase tools 13.0.1
DellaBitta Dec 12, 2023
8eefbbe
use firebase tools 12.9.1
DellaBitta Dec 12, 2023
965ba49
remove push trigger for E2E workflow
DellaBitta Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/deploy-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ jobs:
with:
# This makes Actions fetch all Git history so run-changed script can diff properly.
fetch-depth: 0
- name: Set up node (16)
- name: Set up node (18)
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: Yarn install
run: yarn
- name: Deploy project config if needed
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/e2e-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ jobs:
steps:
- name: Checkout Repo
uses: actions/checkout@master
- name: Set up Node (16)
- name: Set up Node (18)
uses: actions/setup-node@master
with:
node-version: 16.x
node-version: 18.x
- name: install Chrome stable
run: |
sudo apt-get update
Expand All @@ -60,7 +60,7 @@ jobs:
pushd functions
npm install
popd
npx firebase-tools deploy --only functions:callTest --project jscore-sandbox-141b5 --token $FIREBASE_CLI_TOKEN
npx firebase-tools@12.9.1 deploy --only functions:callTest --project jscore-sandbox-141b5 --token $FIREBASE_CLI_TOKEN
working-directory: ./config
env:
FIREBASE_CLI_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}
Expand Down