Firestore: withRetry test helper added #7411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a query should use bloom filter to avoid full requery'
|
…ectionReference and Firestore
Size Report 1Affected ProductsNo changes between base commit (d41ee2f) and merge commit (a7d13b8).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (d41ee2f) and merge commit (a7d13b8).Test Logs |
milaGGL
reviewed
Jul 4, 2023
milaGGL
approved these changes
Jul 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
withRetry()helper function to the Firestore integration testing utility library. This function takes an async function as an argument, calls it, and awaits the Promise that it returns. If the Promise is rejected withRetryErrorthen the async function is simply called again. If the Promise resolves successfully or is rejected with any other exception then the Promise returned fromwithRetry()is resolved/rejected in the same manner.The test
'resuming a query should use bloom filter to avoid full requery'inquery.test.tsis modified to use this new helper function. An upcoming change, #7412, will also use this newwithRetry()helper function.