Add test 'bloom filter should correctly encode special unicode characters' to query.test.ts #7412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a query should use bloom filter to avoid full requery'
…ters' to query.test.ts
|
…ectionReference and Firestore
…oomFilterUnicodeTest
Size Report 1Affected ProductsNo changes between base commit (aea4a44) and merge commit (8f7aea7).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (aea4a44) and merge commit (8f7aea7).Test Logs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test
'bloom filter should correctly encode special unicode characters'toquery.test.ts. This test verifies that the bloom filter correctly encodes document paths that contain special Unicode characters, like combining characters and characters above 0xFFFF (i.e. characters outside of the BMP, basic multilingual plane).Some great background information about JavaScript and Unicode can be found here: https://dmitripavlutin.com/what-every-javascript-developer-should-know-about-unicode/
Googlers see b/289233003 for details.
This PR is ported to the Android SDK in firebase/firebase-android-sdk#5135 and to the iOS SDK in firebase/firebase-ios-sdk#11679.