File tree 1 file changed +4
-11
lines changed
packages/firestore/test/integration/api
1 file changed +4
-11
lines changed Original file line number Diff line number Diff line change @@ -2139,16 +2139,6 @@ apiDescribe('Queries', persistence => {
2139
2139
) ;
2140
2140
}
2141
2141
2142
- // Skip the verification of the existence filter mismatch when the local
2143
- // cache is configured to use eager garbage collection because with eager
2144
- // GC there is no resume token specified in the subsequent call to
2145
- // getDocs(), and, therefore, Watch will _not_ send an existence filter.
2146
- // TODO(b/272754156) Re-write this test using a snapshot listener instead
2147
- // of calls to getDocs() and remove this check for disabled persistence.
2148
- if ( persistence . gc === 'eager' ) {
2149
- return 'passed' ;
2150
- }
2151
-
2152
2142
// Skip the verification of the existence filter mismatch when testing
2153
2143
// against the Firestore emulator because the Firestore emulator fails to
2154
2144
// to send an existence filter at all.
@@ -2209,7 +2199,10 @@ apiDescribe('Queries', persistence => {
2209
2199
while ( true ) {
2210
2200
attemptNumber ++ ;
2211
2201
const iterationResult = await withTestCollection (
2212
- persistence ,
2202
+ // Ensure that the local cache is configured to use LRU garbage
2203
+ // collection (rather than eager garbage collection) so that the resume
2204
+ // token and document data does not get prematurely evicted.
2205
+ persistence . toLruGc ( ) ,
2213
2206
testDocs ,
2214
2207
runTestIteration
2215
2208
) ;
You can’t perform that action at this time.
0 commit comments