Skip to content

Commit d41ee2f

Browse files
authored
Firestore: query.test.ts: use LRUGC in bloom filter tests (#7401)
1 parent 675ec3a commit d41ee2f

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

packages/firestore/test/integration/api/query.test.ts

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2139,16 +2139,6 @@ apiDescribe('Queries', persistence => {
21392139
);
21402140
}
21412141

2142-
// Skip the verification of the existence filter mismatch when the local
2143-
// cache is configured to use eager garbage collection because with eager
2144-
// GC there is no resume token specified in the subsequent call to
2145-
// getDocs(), and, therefore, Watch will _not_ send an existence filter.
2146-
// TODO(b/272754156) Re-write this test using a snapshot listener instead
2147-
// of calls to getDocs() and remove this check for disabled persistence.
2148-
if (persistence.gc === 'eager') {
2149-
return 'passed';
2150-
}
2151-
21522142
// Skip the verification of the existence filter mismatch when testing
21532143
// against the Firestore emulator because the Firestore emulator fails to
21542144
// to send an existence filter at all.
@@ -2209,7 +2199,10 @@ apiDescribe('Queries', persistence => {
22092199
while (true) {
22102200
attemptNumber++;
22112201
const iterationResult = await withTestCollection(
2212-
persistence,
2202+
// Ensure that the local cache is configured to use LRU garbage
2203+
// collection (rather than eager garbage collection) so that the resume
2204+
// token and document data does not get prematurely evicted.
2205+
persistence.toLruGc(),
22132206
testDocs,
22142207
runTestIteration
22152208
);

0 commit comments

Comments
 (0)