Firestore: query.test.ts: use LRUGC in bloom filter tests #7401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen persistence=false
|
Size Report 1Affected ProductsNo changes between base commit (675ec3a) and merge commit (07f2420).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (675ec3a) and merge commit (07f2420).Test Logs |
milaGGL
reviewed
Jun 28, 2023
| const localCache = persistence | ||
| ? persistentLocalCache() | ||
| : memoryLocalCache({ garbageCollector: memoryLruGarbageCollector() }); | ||
|
|
There was a problem hiding this comment.
While running locally against Prod, it is not using bloom filter:
…ralization [no actions]
…WithMemoryLruGc [skip actions]
…Generalization' into BloomFilterTestRunsWithMemoryLruGc
dconeybe
changed the base branch from
master
to
dconeybe/PersistenceTestGeneralization
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Firestore's bloom filter integration test exited early when testing without persistence; however, now that LRU garbage collection is supported for memory persistence, this test can run even with memory persistence as long as LRU GC is enabled (rather than the default, eager GC).
This PR updates the integration test framework to allow tests to specify a specific persistence configuration and the
resuming a query should use bloom filter to avoid full requerytest leverages this new functionality to use LRU GC when persistence=false, allowing the entire test to run to completion in both persistence modes.