Skip to content

Firestore: query.test.ts: use LRUGC in bloom filter tests #7401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 4, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions packages/firestore/test/integration/api/query.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2139,16 +2139,6 @@ apiDescribe('Queries', persistence => {
);
}

// Skip the verification of the existence filter mismatch when the local
// cache is configured to use eager garbage collection because with eager
// GC there is no resume token specified in the subsequent call to
// getDocs(), and, therefore, Watch will _not_ send an existence filter.
// TODO(b/272754156) Re-write this test using a snapshot listener instead
// of calls to getDocs() and remove this check for disabled persistence.
if (persistence.gc === 'eager') {
return 'passed';
}

// Skip the verification of the existence filter mismatch when testing
// against the Firestore emulator because the Firestore emulator fails to
// to send an existence filter at all.
Expand Down Expand Up @@ -2209,7 +2199,10 @@ apiDescribe('Queries', persistence => {
while (true) {
attemptNumber++;
const iterationResult = await withTestCollection(
persistence,
// Ensure that the local cache is configured to use LRU garbage
// collection (rather than eager garbage collection) so that the resume
// token and document data does not get prematurely evicted.
persistence.toLruGc(),
testDocs,
runTestIteration
);
Expand Down