Skip to content

Mila/count #6597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Sep 16, 2022
Merged

Mila/count #6597

merged 29 commits into from
Sep 16, 2022

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Sep 13, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 0267c69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Minor
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 13, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (5b696de)Merge (c874cdc)Diff
    browser264 kB264 kB+60 B (+0.0%)
    esm5327 kB327 kB+139 B (+0.0%)
    main526 kB527 kB+1.78 kB (+0.3%)
    module264 kB264 kB+60 B (+0.0%)
    react-native264 kB264 kB+60 B (+0.0%)

  • @firebase/firestore-lite

    TypeBase (5b696de)Merge (c874cdc)Diff
    browser80.9 kB80.9 kB+62 B (+0.1%)
    esm596.7 kB96.8 kB+141 B (+0.1%)
    main136 kB136 kB+123 B (+0.1%)
    module80.9 kB80.9 kB+62 B (+0.1%)
    react-native81.1 kB81.1 kB+62 B (+0.1%)

  • bundle

    12 size changes

    TypeBase (5b696de)Merge (c874cdc)Diff
    firestore (Persistence)273 kB273 kB+60 B (+0.0%)
    firestore (Query Cursors)209 kB209 kB+60 B (+0.0%)
    firestore (Query)210 kB211 kB+60 B (+0.0%)
    firestore (Read data once)199 kB199 kB+60 B (+0.0%)
    firestore (Realtime updates)201 kB201 kB+60 B (+0.0%)
    firestore (Transaction)183 kB183 kB+60 B (+0.0%)
    firestore (Write data)183 kB183 kB+60 B (+0.0%)
    firestore-lite (Query Cursors)68.3 kB68.4 kB+62 B (+0.1%)
    firestore-lite (Query)71.5 kB71.5 kB+62 B (+0.1%)
    firestore-lite (Read data once)55.9 kB55.9 kB+62 B (+0.1%)
    firestore-lite (Transaction)80.5 kB80.5 kB+62 B (+0.1%)
    firestore-lite (Write data)65.6 kB65.7 kB+62 B (+0.1%)

  • firebase

    TypeBase (5b696de)Merge (c874cdc)Diff
    firebase-compat.js738 kB738 kB+60 B (+0.0%)
    firebase-firestore-compat.js313 kB313 kB+60 B (+0.0%)
    firebase-firestore-lite.js86.3 kB86.3 kB+62 B (+0.1%)
    firebase-firestore.js311 kB311 kB+60 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/eO0m8TnejE.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 13, 2022 •
edited
Loading

Size Analysis Report 1

This report is too large (291,554 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/pUXQ72X0Zj.html

@milaGGL milaGGL requested a review from dconeybe September 15, 2022 16:26
dconeybe
dconeybe requested changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I had a few ideas that popped up that should have come up in my earlier reviews. PTAL and let me know what you think.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2022 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@milaGGL milaGGL requested a review from egilmorez as a code owner September 15, 2022 21:27
@milaGGL milaGGL requested a review from dconeybe September 16, 2022 00:24
dconeybe
dconeybe requested changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 minor comments then I think we're good!

.changeset/hot-insects-wink.md Outdated
'@firebase/firestore': minor
---

Release count query for internal use.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "Release" -> "Implement"

packages/firestore/src/core/firestore_client.ts Outdated
}
const result = await getCount(query);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 529 and 530 still need to be in an "else" block.

@milaGGL milaGGL merged commit e35db6f into master Sep 16, 2022
@milaGGL milaGGL deleted the mila/count branch September 16, 2022 19:51
bhparijat pushed a commit that referenced this pull request Sep 23, 2022
@milaGGL @bhparijat
Mila/count (#6597)
9f59cbd
@dconeybe dconeybe mentioned this pull request Sep 28, 2022
Merged
@google-oss-bot google-oss-bot mentioned this pull request Sep 29, 2022
Merged
@dconeybe dconeybe mentioned this pull request Oct 3, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

@hsubox76 hsubox76 Awaiting requested review from hsubox76

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@dconeybe dconeybe

@milaGGL milaGGL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milaGGL @google-oss-bot @dconeybe