Skip to content

Enable COUNT integration tests, now that backend support has rolled out #6649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2022
Merged

Enable COUNT integration tests, now that backend support has rolled out #6649

merged 3 commits into from
Oct 3, 2022

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Oct 3, 2022

Enable the integration tests for COUNT that were added in #6597 now that the RunAggregationQuery RPC has been fully rolled out.

@dconeybe dconeybe self-assigned this Oct 3, 2022
@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 33387ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 3, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (de32c24) and merge commit (4c25c20).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/u5WkqNNRjk.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 3, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (de32c24) and merge commit (4c25c20).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VsyDl25I4S.html

@dconeybe dconeybe marked this pull request as ready for review October 3, 2022 19:56
@dconeybe dconeybe requested a review from milaGGL October 3, 2022 19:56
milaGGL
milaGGL approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests all passed. LGTM.

@milaGGL milaGGL merged commit 34ad43c into master Oct 3, 2022
@milaGGL milaGGL deleted the dconeybe/CountIntegrationTestEnableInCI branch October 3, 2022 23:58
@firebase firebase locked and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

@cherylEnkidu cherylEnkidu cherylEnkidu approved these changes

@milaGGL milaGGL milaGGL approved these changes

Assignees

@dconeybe dconeybe

@milaGGL milaGGL

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dconeybe @google-oss-bot @ehsannas @cherylEnkidu @milaGGL