Skip to content

Mila/count update proto #6482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 28, 2022
Merged

Mila/count update proto #6482

merged 7 commits into from
Jul 28, 2022

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Jul 28, 2022 •
edited
Loading

Proto is updated based on the changes in this PR: firebase/firebase-android-sdk#3847

@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: c98aa63

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 28, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (f5426a5) and merge commit (f2b51cb).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/n4lKQFcjGE.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 28, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (f5426a5) and merge commit (f2b51cb).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/w1dpawJS71.html

@milaGGL milaGGL self-assigned this Jul 28, 2022
@milaGGL milaGGL marked this pull request as ready for review July 28, 2022 17:18
@milaGGL milaGGL requested a review from dconeybe July 28, 2022 17:23
dconeybe
dconeybe requested changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I've left a few minor comments to address.

@milaGGL milaGGL requested a review from dconeybe July 28, 2022 18:35
@milaGGL milaGGL requested a review from dconeybe July 28, 2022 18:48
@milaGGL milaGGL merged commit b92e492 into mila/count Jul 28, 2022
@milaGGL milaGGL deleted the mila/count-update-proto branch July 28, 2022 20:07
@firebase firebase locked and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@dconeybe dconeybe

@milaGGL milaGGL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milaGGL @google-oss-bot @dconeybe