Skip to content

Online Count with tentative package private api #3847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 51 commits into from
Aug 29, 2022
Merged

Online Count with tentative package private api #3847

merged 51 commits into from
Aug 29, 2022

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Jun 27, 2022

No description provided.

dconeybe added 30 commits June 3, 2022 15:05
@dconeybe
Update protos to googleapis HEAD at googleapis/googleapis@13f9b89
12fc017
@dconeybe
write.proto: add back string verify = 5
3f3a823
@dconeybe
Update protos to googleapis HEAD of the preview branch at googleapis/…
d8dab8e 
…googleapis@77a0a97
@dconeybe
write.proto: add back string verify = 5
3ffc859
@dconeybe
Add API skeleton to aggregate queries and COUNT
f5b5ec4
@dconeybe
Datastore.java: runCountQuery() added
3112d79
@dconeybe
wire up count queries
728f4cb
@dconeybe
delete group-by stuff, since it's not needed for this experiment
ec2be89
@dconeybe
CountTest.java added
3f2a539
@dconeybe
Revert changes to Firestore.kt, since this prototype only uses java
dccef12
@dconeybe
AggregateField.java: remove everything except COUNT
20b6f61
@dconeybe
AggregateSnapshot.java deleted, since it's not used in this prototype
4eee46c
@dconeybe
revert a bunch of other unnecssary changes
41ce0a8
@dconeybe
Collapse CountQuery.java into AggregateQuery.java for simplicity
931c8a6
@dconeybe
/gradlew :firebase-firestore:googleJavaFormat
57aa89b
@dconeybe
AggregateField.java: remove CountAggregateField.upTo, since it's neve…
e95066c 
…r used in this prototype
@dconeybe
Update protos to googleapis HEAD at googleapis/googleapis@13f9b89
20a7e10
@dconeybe
write.proto: add back string verify = 5
92c5218
@dconeybe
Update protos to googleapis HEAD of the preview branch at googleapis/…
5130d16 
…googleapis@77a0a97
@dconeybe
write.proto: add back string verify = 5
9c3a336
@dconeybe
Add API skeleton to aggregate queries and COUNT
74e6d14
@dconeybe
Datastore.java: runCountQuery() added
4155ac6
@dconeybe
wire up count queries
6b34e44
@dconeybe
delete group-by stuff, since it's not needed for this experiment
8dded2c
@dconeybe
CountTest.java added
12b5cd1
@dconeybe
Revert changes to Firestore.kt, since this prototype only uses java
77beb18
@dconeybe
AggregateField.java: remove everything except COUNT
bcf0bcf
@dconeybe
AggregateSnapshot.java deleted, since it's not used in this prototype
9aef43a
@dconeybe
revert a bunch of other unnecssary changes
01420e4
@dconeybe
Collapse CountQuery.java into AggregateQuery.java for simplicity
965144b
dconeybe
dconeybe requested changes Jul 25, 2022
View reviewed changes
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.AggregateQuerySnapshot.getQuery() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@milaGGL milaGGL mentioned this pull request Jul 28, 2022
Merged
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.AggregateQuerySnapshot.getQuery() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

1 similar comment
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.AggregateQuerySnapshot.getQuery() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 15, 2022 •
edited
Loading

@wu-hui: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 09685a4 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Removed class com.google.firebase.firestore.AggregateQuery [RemovedClass]
error: Removed class com.google.firebase.firestore.AggregateQuerySnapshot [RemovedClass]
error: Removed class com.google.firebase.firestore.AggregateSource [RemovedClass]
error: Removed method com.google.firebase.firestore.Query.count() [RemovedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@wu-hui wu-hui changed the title [Do Not Submit] Online Count Online Count Aug 22, 2022
dconeybe
dconeybe requested changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just about ready! Nice work.

@dconeybe dconeybe assigned wu-hui and unassigned dconeybe Aug 23, 2022
@wu-hui wu-hui assigned dconeybe and unassigned wu-hui Aug 26, 2022
@dconeybe dconeybe assigned wu-hui and unassigned dconeybe Aug 26, 2022
@wu-hui wu-hui changed the title Online Count Online Count with tentative package private api Aug 29, 2022
@wu-hui wu-hui merged commit a50da9f into master Aug 29, 2022
@wu-hui wu-hui deleted the wuandy/CountFromDFE branch August 29, 2022 13:50
This was referenced Sep 22, 2022
Closed
Closed
Closed
@firebase firebase locked and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@wu-hui wu-hui

Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wu-hui @google-oss-bot @dconeybe