Skip to content

Firestore: Fix COUNT APIs to match the API proposal #4127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Firestore: Fix COUNT APIs to match the API proposal #4127

wants to merge 2 commits into from

Conversation

dconeybe
Copy link
Contributor

This is a follow-up to #3847 to modify the API surface of the new Query.count() feature to match the API proposal go/firestore-count-api-client-proposal.

@dconeybe dconeybe self-assigned this Sep 22, 2022
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.26% (ed10eb5) to 44.25% (8b60189) by -0.00%.

    FilenameBase (ed10eb5)Merge (8b60189)Diff
    SetMutation.java97.22%94.44%-2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7Bdfl8PNMm.html

@github-actions
Copy link
Contributor

Unit Test Results

     79 files   -    311       79 suites   - 311   54s ⏱️ - 17m 7s
1 097 tests  - 3 603  1 081 ✔️  - 3 595  16 💤  - 6  0 ❌  - 2 
1 097 runs   - 3 619  1 081 ✔️  - 3 611  16 💤  - 6  0 ❌  - 2 

Results for commit a6b60a1. ± Comparison against base commit ed10eb5.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (ed10eb5)Merge (8b60189)Diff
    aar1.30 MB1.30 MB-47 B (-0.0%)
    apk (release)3.32 MB3.32 MB-100 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jSnBDnomRO.html

@dconeybe dconeybe marked this pull request as ready for review September 22, 2022 15:43
@dconeybe dconeybe requested a review from wu-hui September 22, 2022 15:43
@dconeybe
Copy link
Contributor Author

Closing in favor of #4130

@dconeybe dconeybe closed this Sep 22, 2022
@dconeybe dconeybe deleted the dconeybe/CountFixApisToMatchProposal branch September 22, 2022 16:01
@firebase firebase locked and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui Awaiting requested review from wu-hui

Assignees

@wu-hui wu-hui

@dconeybe dconeybe

Labels
api: firestore no-changelog size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @google-oss-bot @wu-hui