Skip to content

Upload release tags on behalf of google-oss-bot. #6380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

yifanyang
Copy link
Contributor

There is another workflow [1] that listens to tag push events.

However, this workflow is not being triggered by new tags
currently, due to the fact that tag push commands
(git push <tag-name>) initiated by GitHub Actions bot do not
trigger other workflows [2].

Switching to a personal GitHub account (in our case the
google-oss-bot) should fix the problem.

[1] https://github.com/firebase/firebase-js-sdk/blob/master/.github/workflows/health-metrics-release.yml
[2] https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow

There is another workflow [1] that listens to tag push events.

However, this workflow is not being triggered by new tags
currently, due to the fact that tag push commands
(`git push <tag-name>`) initiated by GitHub Actions bot do not
trigger other workflows [2].

Switching to a personal GitHub account (in our case the
`google-oss-bot`) should fix the problem.

[1] https://github.com/firebase/firebase-js-sdk/blob/master/.github/workflows/health-metrics-release.yml
[2] https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow
@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2022

⚠️ No Changeset found

Latest commit: c03d127

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yifanyang yifanyang merged commit bf4959b into master Jun 23, 2022
@yifanyang yifanyang deleted the yifany/tags-upload branch June 23, 2022 16:53
@firebase firebase locked and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants