Skip to content

Add debug output for release tags pushing. #6401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

yifanyang
Copy link
Contributor

For some reason, the last release still did not trigger the workflow for uploading tags (history), even after #6380.

The log of the last release job ended at creating tags locally. I would like to add more debugging output to understand what happened while pushing release tags.

@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2022

⚠️ No Changeset found

Latest commit: cfccf7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 29, 2022

Size Report 1

Affected Products

  • @firebase/analytics

    TypeBase (47fefc2)Merge (95f98f4)Diff
    browser19.6 kB20.1 kB+509 B (+2.6%)
    esm524.2 kB24.7 kB+509 B (+2.1%)
    main25.4 kB26.0 kB+574 B (+2.3%)
    module19.6 kB20.1 kB+509 B (+2.6%)
  • bundle

    TypeBase (47fefc2)Merge (95f98f4)Diff
    analytics (logEvent)41.8 kB41.8 kB+47 B (+0.1%)
  • firebase

    TypeBase (47fefc2)Merge (95f98f4)Diff
    firebase-analytics-compat.js25.8 kB25.8 kB+38 B (+0.1%)
    firebase-analytics.js113 kB115 kB+1.60 kB (+1.4%)
    firebase-compat.js794 kB794 kB+38 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/A6yg5DUHOw.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 29, 2022

Size Analysis Report 1

Affected Products

  • @firebase/analytics

    • getAnalytics

      Size

      TypeBase (47fefc2)Merge (95f98f4)Diff
      size9.94 kB9.99 kB+47 B (+0.5%)
      size-with-ext-deps36.0 kB36.0 kB+47 B (+0.1%)
    • initializeAnalytics

      Size

      TypeBase (47fefc2)Merge (95f98f4)Diff
      size9.83 kB9.88 kB+47 B (+0.5%)
      size-with-ext-deps35.8 kB35.8 kB+47 B (+0.1%)
    • isSupported

      Size

      TypeBase (47fefc2)Merge (95f98f4)Diff
      size9.72 kB9.77 kB+47 B (+0.5%)
      size-with-ext-deps35.4 kB35.4 kB+47 B (+0.1%)
    • logEvent

      Size

      TypeBase (47fefc2)Merge (95f98f4)Diff
      size9.58 kB9.63 kB+47 B (+0.5%)
      size-with-ext-deps35.2 kB35.3 kB+47 B (+0.1%)
    • setAnalyticsCollectionEnabled

      Size

      TypeBase (47fefc2)Merge (95f98f4)Diff
      size9.75 kB9.79 kB+47 B (+0.5%)
      size-with-ext-deps35.4 kB35.4 kB+47 B (+0.1%)
    • setConsent

      Size

      TypeBase (47fefc2)Merge (95f98f4)Diff
      size?9.76 kB? (?)
      size-with-ext-deps?35.4 kB? (?)

      Dependency

      TypeBase (47fefc2)Merge (95f98f4)Diff
      functions?

      23 dependencies

      _initializeAnalytics
      _setConsentDefaultForInit
      attemptFetchDynamicConfigWithRetry
      factory
      fetchDynamicConfig
      fetchDynamicConfigWithRetry
      findGtagScriptOnPage
      getHeaders
      getOrCreateDataLayer
      gtagOnConfig
      gtagOnEvent
      insertScriptTag
      isRetriableError
      logEvent
      logEvent$1
      promiseAllSettled
      registerAnalytics
      setAbortableTimeout
      setConsent
      validateIndexedDB
      warnOnBrowserContextMismatch
      wrapGtag
      wrapOrCreateGtag

      ?
      classes?

      AnalyticsAbortSignal
      AnalyticsService
      RetryData

      ?
      variables?

      23 dependencies

      ANALYTICS_TYPE
      BASE_INTERVAL_MILLIS
      DYNAMIC_CONFIG_URL
      ERRORS
      ERROR_FACTORY
      FETCH_TIMEOUT_MILLIS
      GA_FID_KEY
      GTAG_URL
      LONG_RETRY_FACTOR
      ORIGIN_KEY
      dataLayerName
      defaultConsentSettingsForInit
      defaultRetryData
      dynamicConfigPromisesList
      globalInitDone
      gtagCoreFunction
      gtagName
      initializationPromisesMap
      logger
      measurementIdToAppId
      name
      version
      wrappedGtagFunction

      ?
      enums??

      External Dependency

      ModuleBase (47fefc2)Merge (95f98f4)Diff
      @firebase/app?

      _registerComponent
      registerVersion

      ?
      @firebase/component?

      Component

      ?
      @firebase/logger?

      Logger

      ?
      @firebase/util?

      ErrorFactory
      FirebaseError
      areCookiesEnabled
      calculateBackoffMillis
      getModularInstance
      isBrowserExtension
      isIndexedDBAvailable
      validateIndexedDBOpenable

      ?
    • setCurrentScreen

      Size

      TypeBase (47fefc2)Merge (95f98f4)Diff
      size9.83 kB9.87 kB+47 B (+0.5%)
      size-with-ext-deps35.5 kB35.5 kB+47 B (+0.1%)
    • setDefaultEventParameters

      Size

      TypeBase (47fefc2)Merge (95f98f4)Diff
      size9.70 kB9.75 kB+47 B (+0.5%)
      size-with-ext-deps35.3 kB35.4 kB+47 B (+0.1%)
    • setUserId

      Size

      TypeBase (47fefc2)Merge (95f98f4)Diff
      size9.81 kB9.86 kB+47 B (+0.5%)
      size-with-ext-deps35.5 kB35.5 kB+47 B (+0.1%)
    • setUserProperties

      Size

      TypeBase (47fefc2)Merge (95f98f4)Diff
      size9.89 kB9.94 kB+47 B (+0.5%)
      size-with-ext-deps35.5 kB35.6 kB+47 B (+0.1%)
    • settings

      Size

      TypeBase (47fefc2)Merge (95f98f4)Diff
      size9.71 kB9.75 kB+47 B (+0.5%)
      size-with-ext-deps35.4 kB35.4 kB+47 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/J4qnvclbRp.html

@yifanyang
Copy link
Contributor Author

@hsubox76

It seems that even after #6380, the workflow for uploading tags (history) was still not triggered during the release last Friday.

I'm adding some log output for debugging purpose. Let's wait for the next release and I'll continue my investigation then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants