Skip to content

Commit bf4959b

Browse files
authored
Upload release tags on behalf of google-oss-bot. (#6380)
There is another workflow [1] that listens to tag push events. However, that workflow is not being triggered by new tags currently, due to the GitHub Actions limitation that tag push commands (`git push <tag-name>`) initiated by GitHub Actions bot do not trigger other workflows [2]. Switching to a personal GitHub account (in our case the `google-oss-bot`) should fix the problem. [1] https://github.com/firebase/firebase-js-sdk/blob/master/.github/workflows/health-metrics-release.yml [2] https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow
1 parent 8c52a96 commit bf4959b

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

.github/workflows/health-metrics-pull-request.yml

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
name: Health Metrics
22

3-
on: [push, pull_request]
3+
on:
4+
push:
5+
branches: ['**']
6+
pull_request:
47

58
env:
69
GITHUB_PULL_REQUEST_NUMBER: ${{ github.event.pull_request.number }}

.github/workflows/release-prod.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ jobs:
2121
# Release script requires git history and tags.
2222
fetch-depth: 0
2323
ref: release
24+
token: ${{ secrets.OSS_BOT_GITHUB_TOKEN }}
2425
- name: Yarn install
2526
run: yarn
2627
- name: Publish to NPM
@@ -31,7 +32,6 @@ jobs:
3132
# TODO: Make these flags defaults in the release script.
3233
run: yarn release --releaseType Production --ci --skipTests --skipReinstall --ignoreUnstaged
3334
env:
34-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3535
NPM_TOKEN_ANALYTICS: ${{secrets.NPM_TOKEN_ANALYTICS}}
3636
NPM_TOKEN_ANALYTICS_INTEROP_TYPES: ${{secrets.NPM_TOKEN_ANALYTICS_INTEROP_TYPES}}
3737
NPM_TOKEN_ANALYTICS_TYPES: ${{secrets.NPM_TOKEN_ANALYTICS_TYPES}}

.github/workflows/test-all.yml

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
name: Test All Packages
22

3-
on: push
3+
on:
4+
push:
5+
branches: ['**']
6+
47
env:
58
# make chromedriver detect installed Chrome version and download the corresponding driver
69
DETECT_CHROMEDRIVER_VERSION: true

0 commit comments

Comments
 (0)