fix(auth): fix typings and externs for PhoneAuthProvider.credential #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojeil-google
suggested changes
Jun 14, 2017
typings/app.d.ts
Outdated
| @@ -196,7 +196,7 @@ declare namespace firebase.auth { | |||
|
|
|||
| class PhoneAuthProvider extends PhoneAuthProvider_Instance { | |||
| static PROVIDER_ID : string ; | |||
| static credential (verificationId : string , verificationCode : string ) : firebase.Promise < any > ; | |||
| static credential (verificationId : string , verificationCode : string ) : firebase.auth.AuthProvider ; | |||
There was a problem hiding this comment.
Should be firebase.auth.AuthCredential
There was a problem hiding this comment.
Oops, you're right. Should have double-checked, sorry!
Fixed.
typings/firebase.d.ts
Outdated
| @@ -196,7 +196,7 @@ declare namespace firebase.auth { | |||
|
|
|||
| class PhoneAuthProvider extends PhoneAuthProvider_Instance { | |||
| static PROVIDER_ID : string ; | |||
| static credential (verificationId : string , verificationCode : string ) : firebase.Promise < any > ; | |||
| static credential (verificationId : string , verificationCode : string ) : firebase.auth.AuthProvider ; | |||
There was a problem hiding this comment.
Should be firebase.auth.AuthCredential
bojeil-google
approved these changes
Jun 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Fixes issue #48
Testing
n/a
API Changes
None