Skip to content

Commit bc94aae

Browse files
jsayolbojeil-google
authored andcommitted
fix(auth): fix typings and externs for PhoneAuthProvider.credential (#50)
1 parent ec19fc5 commit bc94aae

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

externs/firebase-auth-externs.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1811,7 +1811,7 @@ firebase.auth.PhoneAuthProvider.PROVIDER_ID;
18111811
* {@link firebase.auth.PhoneAuthProvider#verifyPhoneNumber}.
18121812
* @param {string} verificationCode The verification code sent to the user's
18131813
* mobile device.
1814-
* @return {!firebase.Promise<!firebase.auth.AuthCredential>}
1814+
* @return {!firebase.auth.AuthCredential} The auth provider credential.
18151815
*/
18161816
firebase.auth.PhoneAuthProvider.credential =
18171817
function(verificationId, verificationCode) {};

typings/app.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ declare namespace firebase.auth {
196196

197197
class PhoneAuthProvider extends PhoneAuthProvider_Instance {
198198
static PROVIDER_ID : string ;
199-
static credential (verificationId : string , verificationCode : string ) : firebase.Promise < any > ;
199+
static credential (verificationId : string , verificationCode : string ) : firebase.auth.AuthCredential ;
200200
}
201201
class PhoneAuthProvider_Instance implements firebase.auth.AuthProvider {
202202
constructor (auth ? : firebase.auth.Auth | null ) ;

typings/firebase.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ declare namespace firebase.auth {
196196

197197
class PhoneAuthProvider extends PhoneAuthProvider_Instance {
198198
static PROVIDER_ID : string ;
199-
static credential (verificationId : string , verificationCode : string ) : firebase.Promise < any > ;
199+
static credential (verificationId : string , verificationCode : string ) : firebase.auth.AuthCredential ;
200200
}
201201
class PhoneAuthProvider_Instance implements firebase.auth.AuthProvider {
202202
constructor (auth ? : firebase.auth.Auth | null ) ;

0 commit comments

Comments
 (0)