Skip to content

Error on app.d.ts about static credential #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
condorman opened this issue Jun 12, 2017 · 5 comments
Closed

Error on app.d.ts about static credential #48

condorman opened this issue Jun 12, 2017 · 5 comments

Comments

@condorman
Copy link

condorman commented Jun 12, 2017

Hello,

In app.d.ts and firebase.d.ts the function credential return a Promise, but when i compile the application i have this error in console: " the function .then() missing".
In the firebase-js-sdk the function "credential" return firebase.auth.AuthCredential ?

static credential (verificationId : string , verificationCode : string ) : firebase.Promise < any > ;
==>
static credential (verificationId : string , verificationCode : string ) : firebase.auth.AuthCredential ;

Is a goog solution?

Thank you!

@google-oss-bot
Copy link
Contributor

Hey there! I couldn't figure out what this issue is about, so I've labeled it for a human to triage. Hang tight.

@bojeil-google
Copy link
Contributor

This operation is synchronous and it should return a firebase.auth.AuthCredential. It doesn't return a promise.

@jsayol
Copy link
Contributor

jsayol commented Jun 14, 2017

@bojeil-google - I think @condorman is referring to firebase.auth.PhoneAuthProvider.credential(), which according to the d.ts files and the documentation should return a firebase.Promise<any> but actually (and correctly) returns a firebase.auth.AuthCredential.

@jsayol
Copy link
Contributor

jsayol commented Jun 14, 2017

This has been fixed so this issue can be closed now.

@jshcrowthe
Copy link
Contributor

Thanks @jsayol!

@firebase firebase locked and limited conversation to collaborators Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants